chrome/android/java/res/values-v17/styles.xml - Issue 2786283002: [Android] Add a transparent Activity in Chrome to handle Browser Action Intent

Unified Diff: chrome/android/java/res/values-v17/styles.xml

Issue 2786283002: [Android] Add a transparent Activity in Chrome to handle Browser Action Intent (Closed)

Patch Set: Update base on Ted's comments. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/res/values-v17/styles.xml

diff --git a/chrome/android/java/res/values-v17/styles.xml b/chrome/android/java/res/values-v17/styles.xml

index bfb8e10cec809528b7a31d09a5adde9da5ed9d84..dc7ae4555dace7ba3f361b6fdf998eb1af14c75a 100644

--- a/chrome/android/java/res/values-v17/styles.xml

+++ b/chrome/android/java/res/values-v17/styles.xml

@@ -59,6 +59,15 @@

</style>

+ <style name="FullscreenTransparentActivityTheme" parent="Theme.AppCompat.Light" >

Ted C 2017/04/25 17:30:33 Ahh...gotcha that this needs to extend from AppCom

ltian 2017/04/26 18:43:01 Done.

+ <item name="android:windowBackground">@android:color/transparent</item>

+ <item name="android:windowContentOverlay">@null</item>

+ <item name="android:windowIsFloating">true</item>

Ted C 2017/04/25 17:30:33 do we need this?

ltian 2017/04/26 18:43:01 Yes, if we remove this, only the small row above t

Ted C 2017/04/26 20:50:02 Acknowledged.

+ <item name="android:windowIsTranslucent">true</item>

+ <item name="windowActionBar">false</item>

+ <item name="windowNoTitle">true</item>

+ </style>

Ted C 2017/04/25 17:30:33 Looking at the android source: https://android.goo

ltian 2017/04/26 18:43:01 Done.

<item name="windowActionBar">false</item>

</style>