Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6605)

Unified Diff: chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc

Issue 2786223002: Fix flakiness in DragAndDropBrowserTests (Closed)
Patch Set: Review comments addressed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/accessibility/touch_accessibility_aura_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc
diff --git a/chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc b/chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc
index 83520a2edf2d2e921116764a8f59100ea1e8712c..3b051d1e4770ffbddbd9f7ec241fa3be5e780211 100644
--- a/chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc
+++ b/chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc
@@ -695,19 +695,8 @@ class DragAndDropBrowserTest : public InProcessBrowserTest,
frame = GetFrameByName(frame_name);
DCHECK(frame);
- // Wait until frame contents (e.g. images) have painted (which should happen
- // in the animation frame that *starts* after the onload event - therefore
- // we need to wait for 2 animation frames).
- script = std::string(
- "requestAnimationFrame(function() {\n"
- " requestAnimationFrame(function() {\n"
- " domAutomationController.send(43);\n"
- " });\n"
- "});\n");
- if (!content::ExecuteScriptAndExtractInt(frame, script, &response))
- return false;
- if (response != 43)
- return false;
+ // Wait until frame contents have painted and are ready for hit testing.
+ WaitForChildFrameSurfaceReady(frame);
return true;
}
@@ -838,8 +827,7 @@ IN_PROC_BROWSER_TEST_P(DragAndDropBrowserTest, DragStartInFrame) {
// There is no known way to execute test-controlled tasks during
// a drag-and-drop loop run by Windows OS.
-// Flaky on Linux. crbug.com/704603
-#if defined(OS_WIN) || defined(OS_LINUX)
+#if defined(OS_WIN)
#define MAYBE_DragImageBetweenFrames DISABLED_DragImageBetweenFrames
#else
#define MAYBE_DragImageBetweenFrames DragImageBetweenFrames
« no previous file with comments | « no previous file | content/browser/accessibility/touch_accessibility_aura_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698