Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2317)

Unified Diff: core/dom/URL.idl

Issue 2786203002: Roll 50: Copied IDLs, PYTHON scripts from WebKit removed deleted files in WebCore (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/dom/TreeWalker.idl ('k') | core/dom/URLSearchParams.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/dom/URL.idl
diff --git a/core/dom/URL.idl b/core/dom/URL.idl
index 8bd952734b4b7d3621bb795cb31ec216c898639b..f5df0bb7b387e3645223e4be2a660a8f5288588d 100644
--- a/core/dom/URL.idl
+++ b/core/dom/URL.idl
@@ -27,11 +27,7 @@
// https://url.spec.whatwg.org/#url
[
- // TODO(philipj): There should only be one constructor:
- // Constructor(USVString url, optional USVString base)
- Constructor(USVString url),
- Constructor(USVString url, USVString base),
- Constructor(USVString url, URL base),
+ Constructor(USVString url, optional USVString base),
Exposed=(Window,Worker),
ImplementedAs=DOMURL,
RaisesException=Constructor,
@@ -45,8 +41,8 @@
// TODO(philipj): This should be in a partial interface definition:
// File API
// https://w3c.github.io/FileAPI/#creating-revoking
- // TODO(philipj): Neither the return value nor the argument should be nullable.
- [RaisesException, CallWith=ExecutionContext] static DOMString? createObjectURL(Blob? blob);
+ // TODO(philipj): The return type should not be nullable.
+ [RaisesException, CallWith=ExecutionContext] static DOMString? createObjectURL(Blob blob);
[CallWith=ExecutionContext] static void revokeObjectURL(DOMString url);
};
« no previous file with comments | « core/dom/TreeWalker.idl ('k') | core/dom/URLSearchParams.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698