Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/counters.h

Issue 2786193002: Remove fixed TODOs. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_COUNTERS_H_ 5 #ifndef V8_COUNTERS_H_
6 #define V8_COUNTERS_H_ 6 #define V8_COUNTERS_H_
7 7
8 #include "include/v8.h" 8 #include "include/v8.h"
9 #include "src/allocation.h" 9 #include "src/allocation.h"
10 #include "src/base/atomic-utils.h" 10 #include "src/base/atomic-utils.h"
(...skipping 941 matching lines...) Expand 10 before | Expand all | Expand 10 after
952 HT(compile_eval, V8.CompileEvalMicroSeconds, 1000000, MICROSECOND) \ 952 HT(compile_eval, V8.CompileEvalMicroSeconds, 1000000, MICROSECOND) \
953 /* Serialization as part of compilation (code caching) */ \ 953 /* Serialization as part of compilation (code caching) */ \
954 HT(compile_serialize, V8.CompileSerializeMicroSeconds, 100000, MICROSECOND) \ 954 HT(compile_serialize, V8.CompileSerializeMicroSeconds, 100000, MICROSECOND) \
955 HT(compile_deserialize, V8.CompileDeserializeMicroSeconds, 1000000, \ 955 HT(compile_deserialize, V8.CompileDeserializeMicroSeconds, 1000000, \
956 MICROSECOND) \ 956 MICROSECOND) \
957 /* Total compilation time incl. caching/parsing */ \ 957 /* Total compilation time incl. caching/parsing */ \
958 HT(compile_script, V8.CompileScriptMicroSeconds, 1000000, MICROSECOND) \ 958 HT(compile_script, V8.CompileScriptMicroSeconds, 1000000, MICROSECOND) \
959 /* Total JavaScript execution time (including callbacks and runtime calls */ \ 959 /* Total JavaScript execution time (including callbacks and runtime calls */ \
960 HT(execute, V8.Execute, 1000000, MICROSECOND) \ 960 HT(execute, V8.Execute, 1000000, MICROSECOND) \
961 /* Asm/Wasm */ \ 961 /* Asm/Wasm */ \
962 /* TODO(karlschimpf) Update chrome flags to reflect asm/wasm split. */ \
963 HT(wasm_instantiate_asm_module_time, \ 962 HT(wasm_instantiate_asm_module_time, \
964 V8.WasmInstantiateModuleMicroSeconds.asm, 1000000, MICROSECOND) \ 963 V8.WasmInstantiateModuleMicroSeconds.asm, 1000000, MICROSECOND) \
965 HT(wasm_instantiate_wasm_module_time, \ 964 HT(wasm_instantiate_wasm_module_time, \
966 V8.WasmInstantiateModuleMicroSeconds.wasm, 1000000, MICROSECOND) \ 965 V8.WasmInstantiateModuleMicroSeconds.wasm, 1000000, MICROSECOND) \
967 /* TODO(karlschimpf) Update chrome flags to reflect asm/wasm split. */ \
968 HT(wasm_decode_asm_module_time, V8.WasmDecodeModuleMicroSeconds.asm, \ 966 HT(wasm_decode_asm_module_time, V8.WasmDecodeModuleMicroSeconds.asm, \
969 1000000, MICROSECOND) \ 967 1000000, MICROSECOND) \
970 HT(wasm_decode_wasm_module_time, V8.WasmDecodeModuleMicroSeconds.wasm, \ 968 HT(wasm_decode_wasm_module_time, V8.WasmDecodeModuleMicroSeconds.wasm, \
971 1000000, MICROSECOND) \ 969 1000000, MICROSECOND) \
972 /* TODO(karlschimpf) Update chrome flags to reflect asm/wasm split. */ \
973 HT(wasm_decode_asm_function_time, V8.WasmDecodeFunctionMicroSeconds.asm, \ 970 HT(wasm_decode_asm_function_time, V8.WasmDecodeFunctionMicroSeconds.asm, \
974 1000000, MICROSECOND) \ 971 1000000, MICROSECOND) \
975 HT(wasm_decode_wasm_function_time, V8.WasmDecodeFunctionMicroSeconds.wasm, \ 972 HT(wasm_decode_wasm_function_time, V8.WasmDecodeFunctionMicroSeconds.wasm, \
976 1000000, MICROSECOND) \ 973 1000000, MICROSECOND) \
977 /* TODO(kschimpf) Update chrome flags to reflect asm/wasm split. */ \
978 HT(wasm_compile_asm_module_time, V8.WasmCompileModuleMicroSeconds.asm, \ 974 HT(wasm_compile_asm_module_time, V8.WasmCompileModuleMicroSeconds.asm, \
979 1000000, MICROSECOND) \ 975 1000000, MICROSECOND) \
980 HT(wasm_compile_wasm_module_time, V8.WasmCompileModuleMicroSeconds.wasm, \ 976 HT(wasm_compile_wasm_module_time, V8.WasmCompileModuleMicroSeconds.wasm, \
981 1000000, MICROSECOND) \ 977 1000000, MICROSECOND) \
982 HT(wasm_compile_function_time, V8.WasmCompileFunctionMicroSeconds, 1000000, \ 978 HT(wasm_compile_function_time, V8.WasmCompileFunctionMicroSeconds, 1000000, \
983 MICROSECOND) \ 979 MICROSECOND) \
984 HT(asm_wasm_translation_time, V8.AsmWasmTranslationMicroSeconds, 1000000, \ 980 HT(asm_wasm_translation_time, V8.AsmWasmTranslationMicroSeconds, 1000000, \
985 MICROSECOND) \ 981 MICROSECOND) \
986 HT(wasm_lazy_compilation_time, V8.WasmLazyCompilationMicroSeconds, 1000000, \ 982 HT(wasm_lazy_compilation_time, V8.WasmLazyCompilationMicroSeconds, 1000000, \
987 MICROSECOND) 983 MICROSECOND)
(...skipping 20 matching lines...) Expand all
1008 HM(heap_sample_total_committed, V8.MemoryHeapSampleTotalCommitted) \ 1004 HM(heap_sample_total_committed, V8.MemoryHeapSampleTotalCommitted) \
1009 HM(heap_sample_total_used, V8.MemoryHeapSampleTotalUsed) \ 1005 HM(heap_sample_total_used, V8.MemoryHeapSampleTotalUsed) \
1010 HM(heap_sample_map_space_committed, V8.MemoryHeapSampleMapSpaceCommitted) \ 1006 HM(heap_sample_map_space_committed, V8.MemoryHeapSampleMapSpaceCommitted) \
1011 HM(heap_sample_code_space_committed, V8.MemoryHeapSampleCodeSpaceCommitted) \ 1007 HM(heap_sample_code_space_committed, V8.MemoryHeapSampleCodeSpaceCommitted) \
1012 HM(heap_sample_maximum_committed, V8.MemoryHeapSampleMaximumCommitted) 1008 HM(heap_sample_maximum_committed, V8.MemoryHeapSampleMaximumCommitted)
1013 1009
1014 #define HISTOGRAM_MEMORY_LIST(HM) \ 1010 #define HISTOGRAM_MEMORY_LIST(HM) \
1015 HM(memory_heap_committed, V8.MemoryHeapCommitted) \ 1011 HM(memory_heap_committed, V8.MemoryHeapCommitted) \
1016 HM(memory_heap_used, V8.MemoryHeapUsed) \ 1012 HM(memory_heap_used, V8.MemoryHeapUsed) \
1017 /* Asm/Wasm */ \ 1013 /* Asm/Wasm */ \
1018 /* TODO(karlschimpf) Update chrome flags to reflect asm/wasm split. */ \
1019 HM(wasm_decode_asm_module_peak_memory_bytes, \ 1014 HM(wasm_decode_asm_module_peak_memory_bytes, \
1020 V8.WasmDecodeModulePeakMemoryBytes.asm) \ 1015 V8.WasmDecodeModulePeakMemoryBytes.asm) \
1021 HM(wasm_decode_wasm_module_peak_memory_bytes, \ 1016 HM(wasm_decode_wasm_module_peak_memory_bytes, \
1022 V8.WasmDecodeModulePeakMemoryBytes.wasm) \ 1017 V8.WasmDecodeModulePeakMemoryBytes.wasm) \
1023 HM(wasm_compile_function_peak_memory_bytes, \ 1018 HM(wasm_compile_function_peak_memory_bytes, \
1024 V8.WasmCompileFunctionPeakMemoryBytes) \ 1019 V8.WasmCompileFunctionPeakMemoryBytes) \
1025 /* TODO(karlschimpf) Update chrome flags to reflect asm/wasm split. */ \
1026 HM(wasm_asm_min_mem_pages_count, V8.WasmMinMemPagesCount.asm) \ 1020 HM(wasm_asm_min_mem_pages_count, V8.WasmMinMemPagesCount.asm) \
1027 HM(wasm_wasm_min_mem_pages_count, V8.WasmMinMemPagesCount.wasm) \ 1021 HM(wasm_wasm_min_mem_pages_count, V8.WasmMinMemPagesCount.wasm) \
1028 /* TODO(karlschimpf) Update chrome flags to reflect asm/wasm split. */ \
1029 HM(wasm_asm_max_mem_pages_count, V8.WasmMaxMemPagesCount.asm) \ 1022 HM(wasm_asm_max_mem_pages_count, V8.WasmMaxMemPagesCount.asm) \
1030 HM(wasm_wasm_max_mem_pages_count, V8.WasmMaxMemPagesCount.wasm) \ 1023 HM(wasm_wasm_max_mem_pages_count, V8.WasmMaxMemPagesCount.wasm) \
1031 /* TODO(karlschimpf) Update chrome flags to reflect asm/wasm split. */ \
1032 HM(wasm_asm_function_size_bytes, V8.WasmFunctionSizeBytes.asm) \ 1024 HM(wasm_asm_function_size_bytes, V8.WasmFunctionSizeBytes.asm) \
1033 HM(wasm_wasm_function_size_bytes, V8.WasmFunctionSizeBytes.wasm) \ 1025 HM(wasm_wasm_function_size_bytes, V8.WasmFunctionSizeBytes.wasm) \
1034 /* TODO(karlschimpf) Update chrome flags to reflect asm/wasm split. */ \
1035 HM(wasm_asm_module_size_bytes, V8.WasmModuleSizeBytes.asm) \ 1026 HM(wasm_asm_module_size_bytes, V8.WasmModuleSizeBytes.asm) \
1036 HM(wasm_wasm_module_size_bytes, V8.WasmModuleSizeBytes.wasm) 1027 HM(wasm_wasm_module_size_bytes, V8.WasmModuleSizeBytes.wasm)
1037 1028
1038 // WARNING: STATS_COUNTER_LIST_* is a very large macro that is causing MSVC 1029 // WARNING: STATS_COUNTER_LIST_* is a very large macro that is causing MSVC
1039 // Intellisense to crash. It was broken into two macros (each of length 40 1030 // Intellisense to crash. It was broken into two macros (each of length 40
1040 // lines) rather than one macro (of length about 80 lines) to work around 1031 // lines) rather than one macro (of length about 80 lines) to work around
1041 // this problem. Please avoid using recursive macros of this length when 1032 // this problem. Please avoid using recursive macros of this length when
1042 // possible. 1033 // possible.
1043 #define STATS_COUNTER_LIST_1(SC) \ 1034 #define STATS_COUNTER_LIST_1(SC) \
1044 /* Global Handle Count*/ \ 1035 /* Global Handle Count*/ \
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
1345 1336
1346 explicit Counters(Isolate* isolate); 1337 explicit Counters(Isolate* isolate);
1347 1338
1348 DISALLOW_IMPLICIT_CONSTRUCTORS(Counters); 1339 DISALLOW_IMPLICIT_CONSTRUCTORS(Counters);
1349 }; 1340 };
1350 1341
1351 } // namespace internal 1342 } // namespace internal
1352 } // namespace v8 1343 } // namespace v8
1353 1344
1354 #endif // V8_COUNTERS_H_ 1345 #endif // V8_COUNTERS_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698