Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2786183003: [dart:io] Reland: Adds Platform.localeName (Closed)

Created:
3 years, 8 months ago by zra
Modified:
3 years, 8 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[dart:io] Reland: Adds Platform.localeName The Mac OS build broke because a typedef wasn't added until 10.12. related #29126 Committed: https://github.com/dart-lang/sdk/commit/bc923bed16fb87c44cdea43c9b90b8d1266ff29f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -2 lines) Patch
M CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/patch/io_patch.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/io_natives.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/platform.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/bin/platform.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/bin/platform_android.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/platform_fuchsia.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/platform_linux.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/platform_macos.cc View 2 chunks +55 lines, -0 lines 0 comments Download
M runtime/bin/platform_patch.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/bin/platform_unsupported.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/bin/platform_win.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/io_patch.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/io/platform.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M sdk/lib/io/platform_impl.dart View 1 chunk +13 lines, -0 lines 0 comments Download
A tests/standalone/io/locale_name_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
3 years, 8 months ago (2017-03-30 20:48:49 UTC) #2
zra
TBR
3 years, 8 months ago (2017-03-30 20:50:38 UTC) #3
zra
Committed patchset #1 (id:1) manually as bc923bed16fb87c44cdea43c9b90b8d1266ff29f (presubmit successful).
3 years, 8 months ago (2017-03-30 20:51:52 UTC) #5
Florian Schneider
3 years, 8 months ago (2017-03-30 20:52:21 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698