Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2786163002: [selctors4] Implement :focus-within pseudo-class (Closed)

Created:
3 years, 8 months ago by Manuel Rego
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, devtools-reviews_chromium.org, caseq+blink_chromium.org, blink-reviews-style_chromium.org, pfeldman+blink_chromium.org, blink-reviews-css, sof, eae+blinkwatch, lushnikov+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, kozyatinskiy+blink_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[selctors4] Implement :focus-within pseudo-class This patch adds support for the new ":focus-within" pseudo-class. Most of the patch is basically the regular bolierplate code to add a new selector. Then the interesting changes happen on ContainerNode. The patch is covered by a bunch of tests imported from the W3C test suite (which includes generic tests in addition to the tests from Firefox and WebKit implementations too). Apart from some minor changes on current tests to add the new selector. Intent-to-ship thread is available at: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V3RNBhQelSg BUG=617371

Patch Set 1 #

Patch Set 2 : Fix crash #

Patch Set 3 : Try to fix focus-within-002.html #

Patch Set 4 : Try to fix focus-within-002.html #

Patch Set 5 : Fix crash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/css-selector-text.html View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/css-selector-text-expected.txt View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/css-set-selector-text.html View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/css-set-selector-text-expected.txt View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/make_computed_style_base.py View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSSelector.h View 2 3 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSSelector.cpp View 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.cpp View 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 2 3 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/SharedStyleFinderTest.cpp View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ContainerNode.h View 2 3 3 chunks +10 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 1 2 3 4 3 chunks +35 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleChangeReason.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleChangeReason.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/UserActionElementSet.h View 3 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/UserActionElementSet.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 2 3 4 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp View 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
Manuel Rego
3 years, 8 months ago (2017-04-04 09:23:46 UTC) #1
Description was changed from

==========
[selctors4] Implement :focus-within pseudo-class

This patch adds support for the new ":focus-within" pseudo-class.
Most of the patch is basically the regular bolierplate code
to add a new selector. Then the interesting changes happen
on ContainerNode.

The patch is covered by a bunch of tests imported from
the W3C test suite (which includes generic tests in addition to
the tests from Firefox and WebKit implementations too).
Apart from some minor changes on current tests to add
the new selector.

Intent-to-ship thread is available at:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V3RNBhQelSg

BUG=617371
==========

to

==========
[selctors4] Implement :focus-within pseudo-class

This patch adds support for the new ":focus-within" pseudo-class.
Most of the patch is basically the regular bolierplate code
to add a new selector. Then the interesting changes happen
on ContainerNode.

The patch is covered by a bunch of tests imported from
the W3C test suite (which includes generic tests in addition to
the tests from Firefox and WebKit implementations too).
Apart from some minor changes on current tests to add
the new selector.

Intent-to-ship thread is available at:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V3RNBhQelSg

BUG=617371
==========

Powered by Google App Engine
This is Rietveld 408576698