pkg/mock: fixes for v0.11

pkg/mock/lib/src/mock.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library mock.mock;
 
 // TOOD(kevmoo): just use `Map`
 import 'dart:collection' show LinkedHashMap;
 import 'dart:mirrors';
 
 import 'package:matcher/matcher.dart';
 
 import 'action.dart';
 import 'behavior.dart';
 import 'call_matcher.dart';
 import 'log_entry.dart';
 import 'log_entry_list.dart';
 import 'responder.dart';
 import 'util.dart';
 
 /** The base class for all mocked objects. */
 @proxy
 class Mock {
   /** The mock name. Needed if the log is shared; optional otherwise. */
   final String name;
 
   /** The set of [Behavior]s supported. */
-  final LinkedHashMap<String,Behavior> _behaviors;
+  final LinkedHashMap<String, Behavior> _behaviors;
 
   /** How to handle unknown method calls - swallow or throw. */
   final bool _throwIfNoBehavior;
 
   /** For spys, the real object that we are spying on. */
   final Object _realObject;
 
   /** The [log] of calls made. Only used if [name] is null. */
   LogEntryList log;
 
@@ skipping 39 matching lines @@
   }
 
   /**
    * This constructor creates a spy with no user-defined behavior.
    * This is simply a proxy for a real object that passes calls
    * through to that real object but captures an audit trail of
    * calls made to the object that can be queried and validated
    * later.
    */
   Mock.spy(this._realObject, {this.name, this.log})
-    : _behaviors = null,
-     _throwIfNoBehavior = true {
+      : _behaviors = null,
+        _throwIfNoBehavior = true {
     logging = true;
   }
 
   /**
    * [when] is used to create a new or extend an existing [Behavior].
    * A [CallMatcher] [filter] must be supplied, and the [Behavior]s for
    * that signature are returned (being created first if needed).
    *
    * Typical use case:
    *
@@ skipping 18 matching lines @@
    * thrown.
    */
   noSuchMethod(Invocation invocation) {
     var method = MirrorSystem.getName(invocation.memberName);
     var args = invocation.positionalArguments;
     if (invocation.isGetter) {
       method = 'get $method';
     } else if (invocation.isSetter) {
       method = 'set $method';
       // Remove the trailing '='.
-      if (method[method.length-1] == '=') {
+      if (method[method.length - 1] == '=') {
         method = method.substring(0, method.length - 1);
       }
     }
     if (_behaviors == null) { // Spy.
       var mirror = reflect(_realObject);
       try {
         var result = mirror.delegate(invocation);
         log.add(new LogEntry(name, method, args, Action.PROXY, result));
         return result;
       } catch (e) {
@@ skipping 29 matching lines @@
           if (_logging && b.logging) {
             log.add(new LogEntry(name, method, args, action, value));
           }
           return value;
         } else if (action == Action.THROW) {
           if (_logging && b.logging) {
             log.add(new LogEntry(name, method, args, action, value));
           }
           throw value;
         } else if (action == Action.PROXY) {
-          // TODO(gram): Replace all this with:
-          //     var rtn = reflect(value).apply(invocation.positionalArguments,
-          //         invocation.namedArguments);
-          // once that is supported.
-          var rtn;
-          switch (args.length) {
-            case 0:
-              rtn = value();
-              break;
-            case 1:
-              rtn = value(args[0]);
-              break;
-            case 2:
-              rtn = value(args[0], args[1]);
-              break;
-            case 3:
-              rtn = value(args[0], args[1], args[2]);
-              break;
-            case 4:
-              rtn = value(args[0], args[1], args[2], args[3]);
-              break;
-            case 5:
-              rtn = value(args[0], args[1], args[2], args[3], args[4]);
-              break;
-            case 6:
-              rtn = value(args[0], args[1], args[2], args[3],
-                  args[4], args[5]);
-              break;
-            case 7:
-              rtn = value(args[0], args[1], args[2], args[3],
-                  args[4], args[5], args[6]);
-              break;
-            case 8:
-              rtn = value(args[0], args[1], args[2], args[3],
-                  args[4], args[5], args[6], args[7]);
-              break;
-            case 9:
-              rtn = value(args[0], args[1], args[2], args[3],
-                  args[4], args[5], args[6], args[7], args[8]);
-              break;
-            case 9:
-              rtn = value(args[0], args[1], args[2], args[3],
-                  args[4], args[5], args[6], args[7], args[8], args[9]);
-              break;
-            default:
-              throw new Exception(
-                  "Cannot proxy calls with more than 10 parameters.");
-          }
+          var mir = reflect(value) as ClosureMirror;
+          var rtn = mir.invoke(#call, invocation.positionalArguments,
+              invocation.namedArguments).reflectee;
           if (_logging && b.logging) {
             log.add(new LogEntry(name, method, args, action, rtn));
           }
           return rtn;
         }
       }
     }
     if (matchedMethodName) {
       // User did specify behavior for this method, but all the
       // actions are exhausted. This is considered an error.
@@ skipping 80 matching lines @@
       }
     }
   }
 
   /** Clear both logs and behavior. */
   void reset() {
     resetBehavior();
     clearLogs();
   }
 }