gpu/ipc/in_process_command_buffer.cc - Issue 2786103003: Add half-float IOSurface GpuMemoryBuffer support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/ipc/in_process_command_buffer.cc

Issue 2786103003: Add half-float IOSurface GpuMemoryBuffer support (Closed)

Patch Set: Review feedback Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/ipc/in_process_command_buffer.cc

diff --git a/gpu/ipc/in_process_command_buffer.cc b/gpu/ipc/in_process_command_buffer.cc

index fe7d2fa998ce6b274f30795f76109fc6bf514f92..0b2a86de334661bafbf5268f17f342f33dbb56d3 100644

--- a/gpu/ipc/in_process_command_buffer.cc

+++ b/gpu/ipc/in_process_command_buffer.cc

@@ -707,8 +707,8 @@ int32_t InProcessCommandBuffer::CreateImage(ClientBuffer buffer,

int32_t new_id = next_image_id_.GetNext();

- DCHECK(gpu::IsGpuMemoryBufferFormatSupported(gpu_memory_buffer->GetFormat(),

- capabilities_));

+ DCHECK(gpu::IsImageFromGpuMemoryBufferFormatSupported(

+ gpu_memory_buffer->GetFormat(), capabilities_));

DCHECK(gpu::IsImageFormatCompatibleWithGpuMemoryBufferFormat(

internalformat, gpu_memory_buffer->GetFormat()));