gpu/ipc/client/command_buffer_proxy_impl.cc - Issue 2786103003: Add half-float IOSurface GpuMemoryBuffer support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/ipc/client/command_buffer_proxy_impl.cc

Issue 2786103003: Add half-float IOSurface GpuMemoryBuffer support (Closed)

Patch Set: Review feedback Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/ipc/client/command_buffer_proxy_impl.cc

diff --git a/gpu/ipc/client/command_buffer_proxy_impl.cc b/gpu/ipc/client/command_buffer_proxy_impl.cc

index 9c288090d761fb6dc05998312ac6d9e4622f5aaa..67c4eef1dcb1913ca78a7af305e72e0662c04f3a 100644

--- a/gpu/ipc/client/command_buffer_proxy_impl.cc

+++ b/gpu/ipc/client/command_buffer_proxy_impl.cc

@@ -515,8 +515,8 @@ int32_t CommandBufferProxyImpl::CreateImage(ClientBuffer buffer,

DCHECK_EQ(image_fence_sync, flushed_fence_sync_release_ + 1);

}

- DCHECK(gpu::IsGpuMemoryBufferFormatSupported(gpu_memory_buffer->GetFormat(),

- capabilities_));

+ DCHECK(gpu::IsImageFromGpuMemoryBufferFormatSupported(

+ gpu_memory_buffer->GetFormat(), capabilities_));

DCHECK(gpu::IsImageSizeValidForGpuMemoryBufferFormat(

gfx::Size(width, height), gpu_memory_buffer->GetFormat()));

DCHECK(gpu::IsImageFormatCompatibleWithGpuMemoryBufferFormat(