Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: tools/testing/dart/compiler_configuration.dart

Issue 2786083002: Read platform.dill in the VM. (Closed)
Patch Set: Incorporate review comments and merge. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tests/co19/co19-kernel.status ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library compiler_configuration; 5 library compiler_configuration;
6 6
7 import 'dart:io' show Platform; 7 import 'dart:io' show Platform;
8 8
9 import 'runtime_configuration.dart' show RuntimeConfiguration; 9 import 'runtime_configuration.dart' show RuntimeConfiguration;
10 import 'runtime_configuration.dart' show DartPrecompiledAdbRuntimeConfiguration; 10 import 'runtime_configuration.dart' show DartPrecompiledAdbRuntimeConfiguration;
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 RuntimeConfiguration runtimeConfiguration, 208 RuntimeConfiguration runtimeConfiguration,
209 String buildDir, 209 String buildDir,
210 TestInformation info, 210 TestInformation info,
211 List<String> vmOptions, 211 List<String> vmOptions,
212 List<String> sharedOptions, 212 List<String> sharedOptions,
213 List<String> originalArguments, 213 List<String> originalArguments,
214 CommandArtifact artifact) { 214 CommandArtifact artifact) {
215 List<String> args = []; 215 List<String> args = [];
216 if (useDFE) { 216 if (useDFE) {
217 args.add('--dfe=${buildDir}/gen/kernel-service.dart.snapshot'); 217 args.add('--dfe=${buildDir}/gen/kernel-service.dart.snapshot');
218 args.add('--platform=${buildDir}/patched_sdk/platform.dill');
218 } 219 }
219 if (isChecked) { 220 if (isChecked) {
220 args.add('--enable_asserts'); 221 args.add('--enable_asserts');
221 args.add('--enable_type_checks'); 222 args.add('--enable_type_checks');
222 } 223 }
223 if (hotReload) { 224 if (hotReload) {
224 args.add('--hot-reload-test-mode'); 225 args.add('--hot-reload-test-mode');
225 } else if (hotReloadRollback) { 226 } else if (hotReloadRollback) {
226 args.add('--hot-reload-rollback-test-mode'); 227 args.add('--hot-reload-rollback-test-mode');
227 } 228 }
(...skipping 430 matching lines...) Expand 10 before | Expand all | Expand 10 after
658 exec = "$buildDir/clang_x86/dart_bootstrap"; 659 exec = "$buildDir/clang_x86/dart_bootstrap";
659 } else if (arch == "arm64") { 660 } else if (arch == "arm64") {
660 exec = "$buildDir/clang_x64/dart_bootstrap"; 661 exec = "$buildDir/clang_x64/dart_bootstrap";
661 } 662 }
662 } else { 663 } else {
663 exec = "$buildDir/dart_bootstrap"; 664 exec = "$buildDir/dart_bootstrap";
664 } 665 }
665 var args = new List(); 666 var args = new List();
666 if (useDFE) { 667 if (useDFE) {
667 args.add('--dfe=utils/kernel-service/kernel-service.dart'); 668 args.add('--dfe=utils/kernel-service/kernel-service.dart');
669 args.add('--platform=${buildDir}/patched_sdk/platform.dill');
668 } 670 }
669 args.add("--snapshot-kind=app-aot"); 671 args.add("--snapshot-kind=app-aot");
670 if (useBlobs) { 672 if (useBlobs) {
671 args.add("--snapshot=$tempDir/out.aotsnapshot"); 673 args.add("--snapshot=$tempDir/out.aotsnapshot");
672 args.add("--use-blobs"); 674 args.add("--use-blobs");
673 } else { 675 } else {
674 args.add("--snapshot=$tempDir/out.S"); 676 args.add("--snapshot=$tempDir/out.S");
675 } 677 }
676 if (isAndroid && arch == 'arm') { 678 if (isAndroid && arch == 'arm') {
677 args.add('--no-sim-use-hardfp'); 679 args.add('--no-sim-use-hardfp');
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
963 RuntimeConfiguration runtimeConfiguration, 965 RuntimeConfiguration runtimeConfiguration,
964 String buildDir, 966 String buildDir,
965 TestInformation info, 967 TestInformation info,
966 List<String> vmOptions, 968 List<String> vmOptions,
967 List<String> sharedOptions, 969 List<String> sharedOptions,
968 List<String> originalArguments, 970 List<String> originalArguments,
969 CommandArtifact artifact) { 971 CommandArtifact artifact) {
970 return <String>[]; 972 return <String>[];
971 } 973 }
972 } 974 }
OLDNEW
« no previous file with comments | « tests/co19/co19-kernel.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698