Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Side by Side Diff: tools/testing/dart/compiler_configuration.dart

Issue 2786083002: Read platform.dill in the VM. (Closed)
Patch Set: Allow main to be a field or getter. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« runtime/vm/kernel_reader.cc ('K') | « runtime/vm/object_store.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library compiler_configuration; 5 library compiler_configuration;
6 6
7 import 'dart:io' show Platform; 7 import 'dart:io' show Platform;
8 8
9 import 'runtime_configuration.dart' show RuntimeConfiguration; 9 import 'runtime_configuration.dart' show RuntimeConfiguration;
10 import 'runtime_configuration.dart' show DartPrecompiledAdbRuntimeConfiguration; 10 import 'runtime_configuration.dart' show DartPrecompiledAdbRuntimeConfiguration;
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 RuntimeConfiguration runtimeConfiguration, 207 RuntimeConfiguration runtimeConfiguration,
208 String buildDir, 208 String buildDir,
209 TestInformation info, 209 TestInformation info,
210 List<String> vmOptions, 210 List<String> vmOptions,
211 List<String> sharedOptions, 211 List<String> sharedOptions,
212 List<String> originalArguments, 212 List<String> originalArguments,
213 CommandArtifact artifact) { 213 CommandArtifact artifact) {
214 List<String> args = []; 214 List<String> args = [];
215 if (useDFE) { 215 if (useDFE) {
216 args.add('--dfe=${buildDir}/gen/kernel-service.dart.snapshot'); 216 args.add('--dfe=${buildDir}/gen/kernel-service.dart.snapshot');
217 args.add('--platform=${buildDir}/patched_sdk/platform.dill');
ahe 2017/03/31 10:13:09 How about creating an outline of the platform file
Kevin Millikin (Google) 2017/04/25 18:20:29 That's an excellent suggestion. Let's discuss how
217 } 218 }
218 if (isChecked) { 219 if (isChecked) {
219 args.add('--enable_asserts'); 220 args.add('--enable_asserts');
220 args.add('--enable_type_checks'); 221 args.add('--enable_type_checks');
221 } 222 }
222 if (hotReload) { 223 if (hotReload) {
223 args.add('--hot-reload-test-mode'); 224 args.add('--hot-reload-test-mode');
224 } else if (hotReloadRollback) { 225 } else if (hotReloadRollback) {
225 args.add('--hot-reload-rollback-test-mode'); 226 args.add('--hot-reload-rollback-test-mode');
226 } 227 }
(...skipping 393 matching lines...) Expand 10 before | Expand all | Expand 10 after
620 if (arch == "arm") { 621 if (arch == "arm") {
621 exec = "$buildDir/clang_x86/dart_bootstrap"; 622 exec = "$buildDir/clang_x86/dart_bootstrap";
622 } else if (arch == "arm64") { 623 } else if (arch == "arm64") {
623 exec = "$buildDir/clang_x64/dart_bootstrap"; 624 exec = "$buildDir/clang_x64/dart_bootstrap";
624 } 625 }
625 } else { 626 } else {
626 exec = "$buildDir/dart_bootstrap"; 627 exec = "$buildDir/dart_bootstrap";
627 } 628 }
628 var args = new List(); 629 var args = new List();
629 if (useDFE) { 630 if (useDFE) {
630 args.add('--dfe=utils/kernel-service/kernel-service.dart'); 631 args.add('--dfe=utils/kernel-service/kernel-service.dart');
Vyacheslav Egorov (Google) 2017/04/05 12:21:23 this needs to be modified as well.
Kevin Millikin (Google) 2017/04/25 18:20:29 Done.
631 } 632 }
632 args.add("--snapshot-kind=app-aot"); 633 args.add("--snapshot-kind=app-aot");
633 if (useBlobs) { 634 if (useBlobs) {
634 args.add("--snapshot=$tempDir/out.aotsnapshot"); 635 args.add("--snapshot=$tempDir/out.aotsnapshot");
635 args.add("--use-blobs"); 636 args.add("--use-blobs");
636 } else { 637 } else {
637 args.add("--snapshot=$tempDir/out.S"); 638 args.add("--snapshot=$tempDir/out.S");
638 } 639 }
639 if (isAndroid && arch == 'arm') { 640 if (isAndroid && arch == 'arm') {
640 args.add('--no-sim-use-hardfp'); 641 args.add('--no-sim-use-hardfp');
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
930 RuntimeConfiguration runtimeConfiguration, 931 RuntimeConfiguration runtimeConfiguration,
931 String buildDir, 932 String buildDir,
932 TestInformation info, 933 TestInformation info,
933 List<String> vmOptions, 934 List<String> vmOptions,
934 List<String> sharedOptions, 935 List<String> sharedOptions,
935 List<String> originalArguments, 936 List<String> originalArguments,
936 CommandArtifact artifact) { 937 CommandArtifact artifact) {
937 return <String>[]; 938 return <String>[];
938 } 939 }
939 } 940 }
OLDNEW
« runtime/vm/kernel_reader.cc ('K') | « runtime/vm/object_store.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698