Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: ios/web_view/public/cwv_web_view.h

Issue 2786033002: Expose way to set google api key through CWVWebView class method. (Closed)
Patch Set: added comment to static method Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web_view/public/cwv_web_view.h
diff --git a/ios/web_view/public/cwv_web_view.h b/ios/web_view/public/cwv_web_view.h
index 86de8f52c87bbe10faf941d4d1f072f25e2db55a..7de1bbd5daa12b8bdf553d058808637d96ee3354 100644
--- a/ios/web_view/public/cwv_web_view.h
+++ b/ios/web_view/public/cwv_web_view.h
@@ -61,6 +61,12 @@ CWV_EXPORT
// is reset to 0.0.
@property(nonatomic, readonly) double estimatedProgress;
+// This is used by to communicate with the Translate API, among others.
Eugene But (OOO till 7-30) 2017/03/31 18:15:14 Could you please explain in the comments what argu
jzw1 2017/04/11 08:28:46 Done.
+// This method should be called before any CWVWebViews are instantiated.
Eugene But (OOO till 7-30) 2017/03/31 18:15:14 "before any CWVWebViews are instantiated" or "befo
michaeldo 2017/03/31 20:28:16 IIRC this needs to happen before the object is ins
Hiroshi Ichikawa 2017/04/03 05:28:16 Should it happen even before +[CWV configureWithDe
jzw1 2017/04/11 08:28:46 I'd rather not add "before CWV configureWitDelegat
++ (void)setGoogleAPIKey:(NSString*)googleAPIKey
+ clientID:(NSString*)clientID
+ clientSecret:(NSString*)clientSecret;
+
// |configuration| must not be null
- (instancetype)initWithFrame:(CGRect)frame
configuration:(CWVWebViewConfiguration*)configuration
« ios/web_view/internal/cwv_web_view.mm ('K') | « ios/web_view/internal/cwv_web_view.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698