Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: google_apis/google_api_keys.h

Issue 2786033002: Expose way to set google api key through CWVWebView class method. (Closed)
Patch Set: add some guards so this only works for ios. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | google_apis/google_api_keys.cc » ('j') | google_apis/google_api_keys.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/google_api_keys.h
diff --git a/google_apis/google_api_keys.h b/google_apis/google_api_keys.h
index e10078c330a142b8a3a01a9fba125d4dca75bb89..f1774edc8b06a89962d957d1e4de622d3203d89a 100644
--- a/google_apis/google_api_keys.h
+++ b/google_apis/google_api_keys.h
@@ -73,6 +73,9 @@ std::string GetNonStableAPIKey();
std::string GetRemotingAPIKey();
+// Sets the API key.
+void SetAPIKey(std::string api_key);
Hiroshi Ichikawa 2017/04/13 06:42:55 Can you document that this must be called only bef
Hiroshi Ichikawa 2017/04/13 06:42:55 const std::string& would be better. Same for below
jzw1 2017/04/14 02:10:32 Done.
jzw1 2017/04/14 02:10:32 Done.
+
// Represents the different sets of client IDs and secrets in use.
enum OAuth2Client {
CLIENT_MAIN, // Several different features use this.
@@ -97,6 +100,12 @@ std::string GetOAuth2ClientID(OAuth2Client client);
// in, e.g. URL-escaped if you use it in a URL.
std::string GetOAuth2ClientSecret(OAuth2Client client);
+// Sets the client id for the specified client.
+void SetClientID(std::string client_id, OAuth2Client client);
Hiroshi Ichikawa 2017/04/13 06:42:55 SetOAuth2ClientID would be better to be consistent
jzw1 2017/04/14 02:10:32 Done.
+
+// Sets the client secret for the specified client.
+void SetClientSecret(std::string client_secret, OAuth2Client client);
Roger Tawa OOO till Jul 10th 2017/04/13 17:42:43 As discussed over email, let's put all these SetXX
jzw1 2017/04/14 02:10:32 Done.
+
// Returns the auth token for the data reduction proxy.
std::string GetSpdyProxyAuthValue();
« no previous file with comments | « no previous file | google_apis/google_api_keys.cc » ('j') | google_apis/google_api_keys.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698