Expose way to set google api key through CWVWebView class method.

google_apis/google_api_keys.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "google_apis/google_api_keys.h"
 
 // If you add more includes to this list, you also need to add them to
 // google_api_keys_unittest.cc.
 
 #include <stddef.h>
@@ skipping 188 matching lines @@
     client_secrets_[CLIENT_REMOTING_HOST] = CalculateKeyValue(
         GOOGLE_CLIENT_SECRET_REMOTING_HOST,
         STRINGIZE_NO_EXPANSION(GOOGLE_CLIENT_SECRET_REMOTING_HOST),
         NULL,
         default_client_secret,
         environment.get(),
         command_line);
   }
 
   std::string api_key() const { return api_key_; }
+  void set_api_key(std::string api_key) { api_key_ = api_key; }

[Hiroshi Ichikawa, 2017/04/13 06:42:55]

const std::string&

Same for below.

[jzw1, 2017/04/14 02:10:32]

Done.

[Hiroshi Ichikawa, 2017/04/14 02:19:44]

Looks like this particular one is not fixed yet.

[jzw1, 2017/04/14 02:28:52]

Done.

   std::string api_key_non_stable() const { return api_key_non_stable_; }
   std::string api_key_remoting() const { return api_key_remoting_; }
 
   std::string GetClientID(OAuth2Client client) const {
     DCHECK_LT(client, CLIENT_NUM_ITEMS);
     return client_ids_[client];
   }
+  void SetClientID(std::string client_id, OAuth2Client client) {
+    client_ids_[client] = client_id;
+  }
 
   std::string GetClientSecret(OAuth2Client client) const {
     DCHECK_LT(client, CLIENT_NUM_ITEMS);
     return client_secrets_[client];
   }
+  void SetClientSecret(std::string client_secret, OAuth2Client client) {
+    client_secrets_[client] = client_secret;
+  }
 
   std::string GetSpdyProxyAuthValue() {
 #if defined(SPDY_PROXY_AUTH_VALUE)
     return SPDY_PROXY_AUTH_VALUE;
 #else
     return std::string();
 #endif
   }
 
  private:
@@ skipping 81 matching lines @@
 }
 
 std::string GetNonStableAPIKey() {
   return g_api_key_cache.Get().api_key_non_stable();
 }
 
 std::string GetRemotingAPIKey() {
   return g_api_key_cache.Get().api_key_remoting();
 }
 
+void SetAPIKey(std::string api_key) {
+#if defined(OS_MACOSX)

[Hiroshi Ichikawa, 2017/04/13 06:42:55]

Is this logic MacOS specific? If so, can you make it an error when this is
called on non-Mac, probably with NOTREACHED()? Otherwise, remove this #if. Same
for below.

[Eugene But (OOO till 7-30), 2017/04/13 15:06:25]

Should this be OS_IOS ?

[michaeldo, 2017/04/13 19:28:09]

Per the comment in the header, the method definition there and the entire method
here should be wrapped with #if defined. So on other platforms, this method
shouldn't exist at all.

[jzw1, 2017/04/14 02:10:32]

I changed to OS_IOS to be more specific

[jzw1, 2017/04/14 02:10:32]

Yep.

[jzw1, 2017/04/14 02:10:32]

Done.

+  g_api_key_cache.Get().set_api_key(api_key);
+#endif
+}
+
 std::string GetOAuth2ClientID(OAuth2Client client) {
   return g_api_key_cache.Get().GetClientID(client);
 }
 
 std::string GetOAuth2ClientSecret(OAuth2Client client) {
   return g_api_key_cache.Get().GetClientSecret(client);
 }
 
+void SetClientID(std::string client_id, OAuth2Client client) {
+#if defined(OS_MACOSX)

[michaeldo, 2017/04/13 19:28:09]

Same comment as SetAPIKey, entire method for SetClientID/Secret signatures
should be inside the #if/#endif

[jzw1, 2017/04/14 02:10:32]

Done.

+  g_api_key_cache.Get().SetClientID(client_id, client);
+#endif
+}
+
+void SetClientSecret(std::string client_secret, OAuth2Client client) {
+#if defined(OS_MACOSX)
+  g_api_key_cache.Get().SetClientSecret(client_secret, client);
+#endif
+}
+
 std::string GetSpdyProxyAuthValue() {
   return g_api_key_cache.Get().GetSpdyProxyAuthValue();
 }
 
 bool IsGoogleChromeAPIKeyUsed() {
 #if defined(GOOGLE_CHROME_BUILD) || defined(USE_OFFICIAL_GOOGLE_API_KEYS)
   return true;
 #else
   return false;
 #endif
 }
 
 }  // namespace google_apis