Source/core/rendering/RenderButton.cpp - Issue 278603002: Centering text inside a button set to display flex with justify-content: center is impossible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderButton.cpp

Issue 278603002: Centering text inside a button set to display flex with justify-content: center is impossible (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: New patchset based on comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/button-set-display-flex-justifyContent-center.html ('K') | « LayoutTests/platform/linux/fast/forms/button-set-display-flex-justifyContent-center-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderButton.cpp

diff --git a/Source/core/rendering/RenderButton.cpp b/Source/core/rendering/RenderButton.cpp

index 4a58833036388f69ba2117ec3f5f007b366bb000..0511715042297d9b7d86aa589d54fa731d428b13 100644

--- a/Source/core/rendering/RenderButton.cpp

+++ b/Source/core/rendering/RenderButton.cpp

@@ -97,6 +97,7 @@ void RenderButton::setupInnerStyle(RenderStyle* innerStyle)

innerStyle->setMarginTop(Length());

innerStyle->setMarginBottom(Length());

innerStyle->setFlexDirection(style()->flexDirection());

+ innerStyle->setJustifyContent(style()->justifyContent());

cbiesinger 2014/05/21 00:18:10 Can you add these properties as well: setFlexWrap

harpreet.sk 2014/05/21 06:39:58 Done.

}

bool RenderButton::canHaveGeneratedChildren() const