LayoutTests/fast/forms/button-set-display-flex-justifyContent-center.html - Issue 278603002: Centering text inside a button set to display flex with justify-content: center is impossible

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/button-set-display-flex-justifyContent-center.html

Issue 278603002: Centering text inside a button set to display flex with justify-content: center is impossible (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: New patchset based on comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/platform/linux/fast/forms/button-set-display-flex-justifyContent-center-expected.png » ('j') | Source/core/rendering/RenderButton.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head>

	4 <style>

	5 button {
	cbiesinger 2014/05/21 00:18:10 I think you could make this a reftest, if you styl I think you could make this a reftest, if you style the button right. Try: <button style="border: 0; background-color: white; padding: 0; font-family: sans-serif; font-size: initial;">safd</button> And then in a reftest, the same except use a <div> and additionally display: inline-flex. harpreet.sk 2014/05/21 06:39:58 Done. Show quoted text On 2014/05/21 00:18:10, cbiesinger wrote: > I think you could make this a reftest, if you style the button right. Try: > <button style="border: 0; background-color: white; padding: 0; font-family: > sans-serif; font-size: initial;">safd</button> > > And then in a reftest, the same except use a <div> and additionally display: > inline-flex. Done.
	6 width: 400px;

	7 height: 50px;

	8 }

	9

	10 .flex {

	11 display: flex;

	12 }

	13

	14 .flex-center {

	15 justify-content: center;

	16 }

	17 </style>

	18 </head>

	19 <body>

	20 <h4>Test for BUG=344733: Centering text inside a button set to display flex and justify-content: center is impossible</h4>

	21 <button>text</button>

	22 <button class="flex flex-center">text with justify-content: center</button>

	23 </body>

	24 </html>

OLD	NEW