Issue 2786013: Incremental changes towards more efficient refactoring of gclient.py

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2786013: Incremental changes towards more efficient refactoring of gclient.py (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 11 months ago by M-A Ruel

Modified:
4 years ago

Reviewers:
bradnelson, bradn, brunocalvignac

CC:
chromium-reviews

Visibility:
Public.

Description

Incremental changes towards more efficient refactoring of gclient.py Fix gclient diff & pack to not throw uncatched exceptions when a directory is missing. Reorder things in gclient.py for easier diff later Update revinfo help Add GetScmName(), it will be needed later. TEST=unit tests BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49565

Patch Set 1 #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -36 lines)			Patch
M	gclient.py	View	3 chunks	+17 lines, -10 lines	0 comments	Download
M	gclient_scm.py	View	5 chunks	+26 lines, -17 lines	0 comments	Download
M	gclient_utils.py	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	tests/gclient_scm_test.py	View	2 chunks	+6 lines, -7 lines	0 comments	Download

Trybot results:

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bruno

Actually it should be svn+ssh:// instead of ssh+svn:// in gclient_scm.py

4 years, 11 months ago (2010-06-14 17:55:56 UTC) #3

M-A Ruel

4 years, 11 months ago (2010-06-14 18:17:21 UTC) #4

On 2010/06/14 17:55:56, Bruno wrote:
> Actually it should be svn+ssh:// instead of ssh+svn:// in gclient_scm.py

Thanks, I'll do a separate change for that.

Expand Messages | Collapse Messages