third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js - Issue 2785993002: DevTools: Allow ToolbarMenuButtons to be trigged via keyboard

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js

Issue 2785993002: DevTools: Allow ToolbarMenuButtons to be trigged via keyboard (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js b/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js

index 2c5a8ffa735c4f218e4a91786ec65f69aee631e1..77c9f5409ee00b8cf4c11172197178333dbc5d2d 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js

@@ -745,8 +745,6 @@ UI.ToolbarMenuButton = class extends UI.ToolbarButton {

* @param {!Event} event

_clicked(event) {

- if (!this._triggerTimeout)

pfeldman 2017/03/31 00:02:05 What if there wasn't? At least clearTimeout condit

einbinder 2017/04/03 05:21:26 Done.

- return;

clearTimeout(this._triggerTimeout);

this._trigger(event);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »