Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js

Issue 2785993002: DevTools: Allow ToolbarMenuButtons to be trigged via keyboard (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 727 matching lines...) Expand 10 before | Expand all | Expand 10 after
738 this._contextMenuHandler(contextMenu); 738 this._contextMenuHandler(contextMenu);
739 contextMenu.show(); 739 contextMenu.show();
740 this._lastTriggerTime = Date.now(); 740 this._lastTriggerTime = Date.now();
741 } 741 }
742 742
743 /** 743 /**
744 * @override 744 * @override
745 * @param {!Event} event 745 * @param {!Event} event
746 */ 746 */
747 _clicked(event) { 747 _clicked(event) {
748 if (!this._triggerTimeout)
pfeldman 2017/03/31 00:02:05 What if there wasn't? At least clearTimeout condit
einbinder 2017/04/03 05:21:26 Done.
749 return;
750 clearTimeout(this._triggerTimeout); 748 clearTimeout(this._triggerTimeout);
751 this._trigger(event); 749 this._trigger(event);
752 } 750 }
753 }; 751 };
754 752
755 /** 753 /**
756 * @unrestricted 754 * @unrestricted
757 */ 755 */
758 UI.ToolbarSettingToggle = class extends UI.ToolbarToggle { 756 UI.ToolbarSettingToggle = class extends UI.ToolbarToggle {
759 /** 757 /**
(...skipping 294 matching lines...) Expand 10 before | Expand all | Expand 10 after
1054 /** 1052 /**
1055 * @param {!Common.Setting} setting 1053 * @param {!Common.Setting} setting
1056 * @param {string=} tooltip 1054 * @param {string=} tooltip
1057 * @param {string=} alternateTitle 1055 * @param {string=} alternateTitle
1058 */ 1056 */
1059 constructor(setting, tooltip, alternateTitle) { 1057 constructor(setting, tooltip, alternateTitle) {
1060 super(alternateTitle || setting.title() || '', tooltip); 1058 super(alternateTitle || setting.title() || '', tooltip);
1061 UI.SettingsUI.bindCheckbox(this.inputElement, setting); 1059 UI.SettingsUI.bindCheckbox(this.inputElement, setting);
1062 } 1060 }
1063 }; 1061 };
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698