Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: third_party/WebKit/Source/core/dom/ScriptModuleResolver.h

Issue 2785983002: [ES6 modules] ScriptModule::instantiate with resolveModule cb and error handling (Closed)
Patch Set: add_tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptModuleTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/ScriptModuleResolver.h
diff --git a/third_party/WebKit/Source/core/dom/ScriptModuleResolver.h b/third_party/WebKit/Source/core/dom/ScriptModuleResolver.h
index 72816c9b443375ae502db6e83278515fee2024f5..9bf7dc5f0d2c6b1e0b221c677e043c2b1831b4da 100644
--- a/third_party/WebKit/Source/core/dom/ScriptModuleResolver.h
+++ b/third_party/WebKit/Source/core/dom/ScriptModuleResolver.h
@@ -21,8 +21,10 @@ class ModuleScript;
// the specifier, and the module identified by 'x' is the descendant.
// ScriptModuleResolver, given a referrer and specifier, can look up the
// descendant.
-class ScriptModuleResolver : public GarbageCollected<ScriptModuleResolver> {
+class ScriptModuleResolver
+ : public GarbageCollectedFinalized<ScriptModuleResolver> {
public:
+ virtual ~ScriptModuleResolver() {}
DEFINE_INLINE_VIRTUAL_TRACE() {}
// Notify the ScriptModuleResolver that a ModuleScript exists.
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptModuleTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698