[ES6 modules] ScriptModule::instantiate with resolveModule cb and error handling

third_party/WebKit/Source/bindings/core/v8/ScriptModule.h

Index: third_party/WebKit/Source/bindings/core/v8/ScriptModule.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptModule.h b/third_party/WebKit/Source/bindings/core/v8/ScriptModule.h
index fc51232d7f5d635423021db752bd6d01bb9ff217..c4899fecb9d0787c3092a78ce829dc300ff4fd9e 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptModule.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptModule.h
@@ -26,7 +26,7 @@ class CORE_EXPORT ScriptModule final {
   ScriptModule(const ScriptModule& module) : m_module(module.m_module) {}
   ~ScriptModule();
 
-  bool instantiate(ScriptState*);
+  ScriptValue instantiate(ScriptState*);

[neis, 2017/03/30 06:38:40]

Please add a comment saying that this returns the exception, if any.

[kouhei (in TOK), 2017/03/30 07:13:54]

Done.

   void evaluate(ScriptState*);
 
   bool isNull() const { return m_module->isEmpty(); }
@@ -34,6 +34,11 @@ class CORE_EXPORT ScriptModule final {
  private:
   ScriptModule(v8::Isolate*, v8::Local<v8::Module>);
 
+  static v8::MaybeLocal<v8::Module> resolveModuleCallback(
+      v8::Local<v8::Context>,
+      v8::Local<v8::String> specifier,
+      v8::Local<v8::Module> referrer);
+
   RefPtr<SharedPersistent<v8::Module>> m_module;
 };