DevTools: Fix Network.clearBrowserCookies

chrome/browser/chrome_content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_content_browser_client.h"
 
 #include <map>
 #include <set>
 #include <utility>
 #include <vector>
@@ skipping 2724 matching lines @@
 void ChromeContentBrowserClient::ClearCache(RenderFrameHost* rfh) {
   Profile* profile = Profile::FromBrowserContext(
       rfh->GetSiteInstance()->GetProcess()->GetBrowserContext());
   BrowsingDataRemover* remover =
       BrowsingDataRemoverFactory::GetForBrowserContext(profile);
   remover->Remove(base::Time(), base::Time::Max(),
                   BrowsingDataRemover::DATA_TYPE_CACHE,
                   BrowsingDataRemover::ORIGIN_TYPE_UNPROTECTED_WEB);
 }
 
-void ChromeContentBrowserClient::ClearCookies(RenderFrameHost* rfh) {
-  Profile* profile = Profile::FromBrowserContext(
-      rfh->GetSiteInstance()->GetProcess()->GetBrowserContext());
-  BrowsingDataRemover* remover =
-      BrowsingDataRemoverFactory::GetForBrowserContext(profile);
-  int remove_mask = ChromeBrowsingDataRemoverDelegate::DATA_TYPE_SITE_DATA;

[dgozman, 2017/03/31 22:57:55]

This looks like more than cookies, doesn't it? Let's double check we do
equivalent things.

[phulce, 2017/03/31 23:54:32]

Oh yeah forgot to mention this was clearly a bug too :) When you clear cookies
currently in Network panel context menu, it deletes all localStorage/cache/etc

-  remover->Remove(base::Time(), base::Time::Max(), remove_mask,
-                  BrowsingDataRemover::ORIGIN_TYPE_UNPROTECTED_WEB);
-}
-
 void ChromeContentBrowserClient::ClearSiteData(
     content::BrowserContext* browser_context,
     const url::Origin& origin,
     bool remove_cookies,
     bool remove_storage,
     bool remove_cache,
     const base::Closure& callback) {
   BrowsingDataRemover* remover =
       BrowsingDataRemoverFactory::GetForBrowserContext(browser_context);
 
@@ skipping 814 matching lines @@
     RedirectNonUINonIOBrowserThreadsToTaskScheduler() {
   return variations::GetVariationParamValue(
              "BrowserScheduler", "RedirectNonUINonIOBrowserThreads") == "true";
 }
 
 // static
 void ChromeContentBrowserClient::SetDefaultQuotaSettingsForTesting(
     const storage::QuotaSettings* settings) {
   g_default_quota_settings = settings;
 }