Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc

Issue 2785943004: DCHECK tasks posted by TaskRunner::PostTask (Closed)
Patch Set: s/CHECK/DCHECK/ except for TaskQueueImpl Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/scheduler/base/task_queue_impl.h" 5 #include "platform/scheduler/base/task_queue_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/format_macros.h" 9 #include "base/format_macros.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 200 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 TaskType::NON_NESTABLE); 211 TaskType::NON_NESTABLE);
212 212
213 return PostDelayedTaskImpl(from_here, std::move(task), delay, 213 return PostDelayedTaskImpl(from_here, std::move(task), delay,
214 TaskType::NON_NESTABLE); 214 TaskType::NON_NESTABLE);
215 } 215 }
216 216
217 bool TaskQueueImpl::PostImmediateTaskImpl( 217 bool TaskQueueImpl::PostImmediateTaskImpl(
218 const tracked_objects::Location& from_here, 218 const tracked_objects::Location& from_here,
219 base::Closure task, 219 base::Closure task,
220 TaskType task_type) { 220 TaskType task_type) {
221 // Use CHECK temporaly to debug http://crbug.com/706854 in the wild.
222 // TODO(tzik): Convert this to DCHECK once the issue is resolved.
223 CHECK(task);
224
221 base::AutoLock lock(any_thread_lock_); 225 base::AutoLock lock(any_thread_lock_);
222 if (!any_thread().task_queue_manager) 226 if (!any_thread().task_queue_manager)
223 return false; 227 return false;
224 228
225 EnqueueOrder sequence_number = 229 EnqueueOrder sequence_number =
226 any_thread().task_queue_manager->GetNextSequenceNumber(); 230 any_thread().task_queue_manager->GetNextSequenceNumber();
227 231
228 PushOntoImmediateIncomingQueueLocked(from_here, std::move(task), 232 PushOntoImmediateIncomingQueueLocked(from_here, std::move(task),
229 base::TimeTicks(), sequence_number, 233 base::TimeTicks(), sequence_number,
230 task_type != TaskType::NON_NESTABLE); 234 task_type != TaskType::NON_NESTABLE);
231 return true; 235 return true;
232 } 236 }
233 237
234 bool TaskQueueImpl::PostDelayedTaskImpl( 238 bool TaskQueueImpl::PostDelayedTaskImpl(
235 const tracked_objects::Location& from_here, 239 const tracked_objects::Location& from_here,
236 base::Closure task, 240 base::Closure task,
237 base::TimeDelta delay, 241 base::TimeDelta delay,
238 TaskType task_type) { 242 TaskType task_type) {
243 // Use CHECK temporaly to debug http://crbug.com/706854 in the wild.
244 // TODO(tzik): Convert this to DCHECK once the issue is resolved.
245 CHECK(task);
246
239 DCHECK_GT(delay, base::TimeDelta()); 247 DCHECK_GT(delay, base::TimeDelta());
240 if (base::PlatformThread::CurrentId() == thread_id_) { 248 if (base::PlatformThread::CurrentId() == thread_id_) {
241 // Lock-free fast path for delayed tasks posted from the main thread. 249 // Lock-free fast path for delayed tasks posted from the main thread.
242 if (!main_thread_only().task_queue_manager) 250 if (!main_thread_only().task_queue_manager)
243 return false; 251 return false;
244 252
245 EnqueueOrder sequence_number = 253 EnqueueOrder sequence_number =
246 main_thread_only().task_queue_manager->GetNextSequenceNumber(); 254 main_thread_only().task_queue_manager->GetNextSequenceNumber();
247 255
248 base::TimeTicks time_domain_now = main_thread_only().time_domain->Now(); 256 base::TimeTicks time_domain_now = main_thread_only().time_domain->Now();
(...skipping 633 matching lines...) Expand 10 before | Expand all | Expand 10 after
882 890
883 void TaskQueueImpl::PushImmediateIncomingTaskForTest( 891 void TaskQueueImpl::PushImmediateIncomingTaskForTest(
884 TaskQueueImpl::Task&& task) { 892 TaskQueueImpl::Task&& task) {
885 base::AutoLock lock(any_thread_lock_); 893 base::AutoLock lock(any_thread_lock_);
886 any_thread().immediate_incoming_queue.push_back(std::move(task)); 894 any_thread().immediate_incoming_queue.push_back(std::move(task));
887 } 895 }
888 896
889 } // namespace internal 897 } // namespace internal
890 } // namespace scheduler 898 } // namespace scheduler
891 } // namespace blink 899 } // namespace blink
OLDNEW
« base/task_scheduler/priority_queue_unittest.cc ('K') | « content/renderer/categorized_worker_pool.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698