Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

Issue 2785943002: [Bindings] Simplify V8PrivateProperty::Symbol methods (Closed)
Patch Set: work for comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp
index 76fc7a3690e040406dc42696bd1e0548a072e227..3c01a104711a52fcf76fb018d3d618f9f914f05e 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp
@@ -190,7 +190,7 @@ void V8TestInterfaceNamedConstructorConstructor::NamedConstructorAttributeGetter
// Set the prototype of named constructors to the regular constructor.
auto privateProperty = V8PrivateProperty::getNamedConstructorInitialized(info.GetIsolate());
v8::Local<v8::Context> currentContext = info.GetIsolate()->GetCurrentContext();
- v8::Local<v8::Value> privateValue = privateProperty.get(currentContext, namedConstructor);
+ v8::Local<v8::Value> privateValue = privateProperty.getOrEmpty(namedConstructor);
if (privateValue.IsEmpty()) {
v8::Local<v8::Function> interface = perContextData->constructorForType(&V8TestInterfaceNamedConstructor::wrapperTypeInfo);
@@ -198,7 +198,7 @@ void V8TestInterfaceNamedConstructorConstructor::NamedConstructorAttributeGetter
bool result = namedConstructor->Set(currentContext, v8AtomicString(info.GetIsolate(), "prototype"), interfacePrototype).ToChecked();
if (!result)
return;
- privateProperty.set(currentContext, namedConstructor, v8::True(info.GetIsolate()));
+ privateProperty.set(namedConstructor, v8::True(info.GetIsolate()));
}
v8SetReturnValue(info, namedConstructor);

Powered by Google App Engine
This is Rietveld 408576698