third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp - Issue 2785943002: [Bindings] Simplify V8PrivateProperty::Symbol methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

Issue 2785943002: [Bindings] Simplify V8PrivateProperty::Symbol methods (Closed)

Patch Set: work for comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventTarget.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

index 013b701b55e328883b6274817f0f42ef7ffff2de..d3a17029a5b0ca56cbec4f5ae39f28b6a9a6b8e5 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

@@ -381,7 +381,7 @@ void V8TestInterfaceConstructorConstructor::NamedConstructorAttributeGetter(

// Set the prototype of named constructors to the regular constructor.

auto privateProperty = V8PrivateProperty::getNamedConstructorInitialized(info.GetIsolate());

v8::Local<v8::Context> currentContext = info.GetIsolate()->GetCurrentContext();

- v8::Local<v8::Value> privateValue = privateProperty.get(currentContext, namedConstructor);

+ v8::Local<v8::Value> privateValue = privateProperty.getOrEmpty(namedConstructor);

if (privateValue.IsEmpty()) {

v8::Local<v8::Function> interface = perContextData->constructorForType(&V8TestInterfaceConstructor::wrapperTypeInfo);

@@ -389,7 +389,7 @@ void V8TestInterfaceConstructorConstructor::NamedConstructorAttributeGetter(

bool result = namedConstructor->Set(currentContext, v8AtomicString(info.GetIsolate(), "prototype"), interfacePrototype).ToChecked();

if (!result)

return;

- privateProperty.set(currentContext, namedConstructor, v8::True(info.GetIsolate()));

+ privateProperty.set(namedConstructor, v8::True(info.GetIsolate()));

}

v8SetReturnValue(info, namedConstructor);