third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp - Issue 2785943002: [Bindings] Simplify V8PrivateProperty::Symbol methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp

Issue 2785943002: [Bindings] Simplify V8PrivateProperty::Symbol methods (Closed)

Patch Set: work for comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8MutationCallback.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp b/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp

index f6d0a2b1f7dd91c3de95f3537a7ffb2cf6bfc1b0..eba8f8d5c4757318a76671a94d8d6c9b531424b2 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp

@@ -49,7 +49,7 @@ V8NodeFilterCondition::V8NodeFilterCondition(v8::Local<v8::Value> filter,

// (See the fast/dom/node-filter-gc test for a case where 'empty' happens.)

if (!filter.IsEmpty() && filter->IsObject()) {

V8PrivateProperty::getV8NodeFilterConditionFilter(scriptState->isolate())

- .set(scriptState->context(), owner, filter);

+ .set(owner, filter);

m_filter.set(scriptState->isolate(), filter);

m_filter.setPhantom();

}