third_party/WebKit/Source/bindings/core/v8/custom/V8ErrorEventCustom.cpp - Issue 2785943002: [Bindings] Simplify V8PrivateProperty::Symbol methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8ErrorEventCustom.cpp

Issue 2785943002: [Bindings] Simplify V8PrivateProperty::Symbol methods (Closed)

Patch Set: NOLINT comment hack Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h ('K') | « third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8ErrorEventCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8ErrorEventCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8ErrorEventCustom.cpp

index 140d36c2d5242330e9a4ea3932664829924bd679..ade96fbe1c2a1e20b52414692fd0d075e3d5a6e4 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8ErrorEventCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8ErrorEventCustom.cpp

@@ -41,8 +41,7 @@ void V8ErrorEvent::errorAttributeGetterCustom(

v8::Local<v8::Context> context = isolate->GetCurrentContext();

auto privateError = V8PrivateProperty::getErrorEventError(isolate);

- v8::Local<v8::Value> cachedError =

- privateError.getOrUndefined(context, info.Holder());

+ v8::Local<v8::Value> cachedError = privateError.getOrUndefined(info.Holder());

if (!cachedError->IsUndefined()) {

v8SetReturnValue(info, cachedError);

return;

@@ -54,7 +53,7 @@ void V8ErrorEvent::errorAttributeGetterCustom(

v8::Local<v8::Value> errorValue =

error.isEmpty() ? v8::Local<v8::Value>(v8::Null(isolate))

: error.v8Value();

- privateError.set(context, info.Holder(), errorValue);

+ privateError.set(info.Holder(), errorValue);

v8SetReturnValue(info, errorValue);

}