third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp - Issue 2785943002: [Bindings] Simplify V8PrivateProperty::Symbol methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp

Issue 2785943002: [Bindings] Simplify V8PrivateProperty::Symbol methods (Closed)

Patch Set: NOLINT comment hack Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp b/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp

index 139ed88755d5dc6b65b9f7e211821b49bc008987..4894ea3cf3204faf7673313e8a6d7c455d8713a2 100644

--- a/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp

@@ -255,7 +255,7 @@ void LocalWindowProxy::updateDocumentProperty() {

DCHECK(documentWrapper->IsObject());

// Update the cached accessor for window.document.

CHECK(V8PrivateProperty::getWindowDocumentCachedAccessor(isolate()).set(

- context, context->Global(), documentWrapper));

+ context->Global(), documentWrapper));

}

void LocalWindowProxy::updateActivityLogger() {