third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp - Issue 2785943002: [Bindings] Simplify V8PrivateProperty::Symbol methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

Issue 2785943002: [Bindings] Simplify V8PrivateProperty::Symbol methods (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp » ('j') | third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

index 42b80879dba746d3540b43a2d914dddfdcaec120..e2f8f06626e781570524cb78572f046703c80151 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

@@ -95,7 +95,7 @@ static void keepAlive(v8::Local<v8::Object>& object,

return;

v8::Isolate* isolate = scriptState->isolate();

- symbolGetter(isolate).set(scriptState->context(), object, value);

+ symbolGetter(isolate).set(object, value);

persistent.set(isolate, value);

persistent.setPhantom();

}