Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.cpp

Issue 2785943002: [Bindings] Simplify V8PrivateProperty::Symbol methods (Closed)
Patch Set: work for comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "bindings/core/v8/V8PrivateProperty.h" 5 #include "bindings/core/v8/V8PrivateProperty.h"
6 6
7 #include "bindings/core/v8/ScriptState.h" 7 #include "bindings/core/v8/ScriptState.h"
8 #include "bindings/core/v8/ScriptWrappable.h" 8 #include "bindings/core/v8/ScriptWrappable.h"
9 #include "bindings/core/v8/V8Binding.h" 9 #include "bindings/core/v8/V8Binding.h"
10 #include "bindings/core/v8/V8BindingMacros.h" 10 #include "bindings/core/v8/V8BindingMacros.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 v8::Local<v8::Value> V8PrivateProperty::Symbol::getFromMainWorld( 14 v8::Local<v8::Value> V8PrivateProperty::Symbol::getFromMainWorld(
15 ScriptState* scriptState,
16 ScriptWrappable* scriptWrappable) { 15 ScriptWrappable* scriptWrappable) {
17 v8::Local<v8::Object> wrapper = 16 v8::Local<v8::Object> wrapper = scriptWrappable->mainWorldWrapper(m_isolate);
18 scriptWrappable->mainWorldWrapper(scriptState->isolate()); 17 return wrapper.IsEmpty() ? v8::Local<v8::Value>() : getOrEmpty(wrapper);
19 return wrapper.IsEmpty() ? v8::Local<v8::Value>()
20 : get(scriptState->context(), wrapper);
21 } 18 }
22 19
23 v8::Local<v8::Private> V8PrivateProperty::createV8Private(v8::Isolate* isolate, 20 v8::Local<v8::Private> V8PrivateProperty::createV8Private(v8::Isolate* isolate,
24 const char* symbol, 21 const char* symbol,
25 size_t length) { 22 size_t length) {
26 v8::Local<v8::String> str = 23 v8::Local<v8::String> str =
27 v8::String::NewFromOneByte( 24 v8::String::NewFromOneByte(
28 isolate, reinterpret_cast<const uint8_t*>(symbol), 25 isolate, reinterpret_cast<const uint8_t*>(symbol),
29 v8::NewStringType::kNormal, static_cast<int>(length)) 26 v8::NewStringType::kNormal, static_cast<int>(length))
30 .ToLocalChecked(); 27 .ToLocalChecked();
31 return v8::Private::New(isolate, str); 28 return v8::Private::New(isolate, str);
32 } 29 }
33 30
34 } // namespace blink 31 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698