Extension content verification: new class for parsing data from store

extensions/browser/verified_contents.h

Index: extensions/browser/verified_contents.h
diff --git a/extensions/browser/verified_contents.h b/extensions/browser/verified_contents.h
new file mode 100644
index 0000000000000000000000000000000000000000..036f66424e7e155cb3e147793b0130e8baba9bb2
--- /dev/null
+++ b/extensions/browser/verified_contents.h
@@ -0,0 +1,82 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef EXTENSIONS_BROWSER_VERIFIED_CONTENTS_H_
+#define EXTENSIONS_BROWSER_VERIFIED_CONTENTS_H_
+
+#include <map>
+#include <string>
+#include <vector>
+
+#include "base/files/file_path.h"
+#include "base/version.h"
+
+namespace extensions {
+
+// This class encapsulates the data in a "verified_contents.json" file
+// generated by the webstore for a .crx file. That data includes a set of
+// signed expected hashes of file content which can be used to check for
+// corruption of extension files on local disk.
+class VerifiedContents {
+ public:
+  VerifiedContents(const uint8* public_key, int public_key_size);

[Ken Rockot(use gerrit already), 2014/05/08 20:05:17]

nit: I'm a little wary of constructing this over a raw pointer and hanging onto
its value. Since it is retained and used, are you opposed to copying the data
into an owned vector<uint8>? If so, maybe at least document that the key is not
owned and that the pointee must outlive the VerifiedContents.

[asargent_no_longer_on_chrome, 2014/05/08 21:05:45]

This is going to be used in some performance sensitive code and I want to avoid
copying, so I've added a comment. In practice, we'll using a constant for this,
but it's going to be defined in chrome/ instead of extensions/ "because
componentization" and I'm going to have to pass it though a few layers to get
here.

+  ~VerifiedContents();
+
+  // Returns true if we successfully parsed the verified_contents.json file at
+  // |path| and validated the enclosed signature. The
+  // |ignore_invalid_signature| argument can be set to make this still succeed
+  // if the contents of the file were parsed successfully but the signature did
+  // not validate. (Use with caution!)
+  bool InitFrom(const base::FilePath& path, bool ignore_invalid_signature);
+
+  int block_size() const { return block_size_; }
+  const std::string& extension_id() const { return extension_id_; }
+  const base::Version& version() const { return version_; }
+
+  // This returns a pointer to the binary form of an expected sha256 root hash
+  // for |relative_path| computing using a tree hash algorithm.
+  const std::string* GetTreeHashRoot(const base::FilePath& relative_path);
+
+  // If InitFrom has not been called yet, or was used in "ignore invalid
+  // signature" mode, this can return false.
+  bool valid_signature() { return valid_signature_; }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(VerifiedContents);
+
+  // Returns the base64url-decoded "payload" field from the json at |path|, if
+  // the signature was valid (or ignore_invalid_signature was set to true).
+  bool GetPayload(const base::FilePath& path,
+                  std::string* payload,
+                  bool ignore_invalid_signature);
+
+  // The |protected_value| and |payload| arguments should be base64url encoded
+  // strings, and |signature_bytes| should be a byte array. See comments in the
+  // .cc file on GetPayload for where these come from in the overall input
+  // file.
+  bool VerifySignature(const std::string& protected_value,
+                       const std::string& payload,
+                       const std::string& signature_bytes);
+
+  // The public key we should use for signature verification.
+  const uint8* public_key_;
+  const int public_key_size_;
+
+  // Indicates whether the signature was successfully validated or not.
+  bool valid_signature_;
+
+  // The block size used for computing the treehash root hashes.
+  int block_size_;
+
+  // Information about which extension these signed hashes are for.
+  std::string extension_id_;
+  base::Version version_;
+
+  // The expected treehash root hashes for each file.
+  std::map<base::FilePath, std::string> root_hashes_;
+};
+
+}  // namespace extensions
+
+#endif  // EXTENSIONS_BROWSER_VERIFIED_CONTENTS_H_