Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 278593005: Extension content verification: new class for parsing data from store (Closed)

Created:
6 years, 7 months ago by asargent_no_longer_on_chrome
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Add a class for parsing extension content verification data The webstore will be vending a "verified_contents.json" file for extensions hosted there that contains a signed list of expected block hashes for the files contained in an extension. This new class handles parsing/validation of that data. BUG=369895 R=rockot@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269305

Patch Set 1 #

Total comments: 2

Patch Set 2 : added comment #

Patch Set 3 : fix compile problem on windows #

Patch Set 4 : fix windows compile in unit tests file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+588 lines, -0 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A extensions/browser/verified_contents.h View 1 1 chunk +83 lines, -0 lines 0 comments Download
A extensions/browser/verified_contents.cc View 1 2 1 chunk +312 lines, -0 lines 0 comments Download
A extensions/browser/verified_contents_unittest.cc View 1 2 3 1 chunk +86 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A extensions/test/data/content_verifier/README View 1 chunk +28 lines, -0 lines 0 comments Download
A extensions/test/data/content_verifier/payload.json View 1 chunk +25 lines, -0 lines 0 comments Download
A extensions/test/data/content_verifier/private_key.pem View 1 chunk +27 lines, -0 lines 0 comments Download
A extensions/test/data/content_verifier/public_key.pem View 1 chunk +9 lines, -0 lines 0 comments Download
A extensions/test/data/content_verifier/verified_contents.json View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
asargent_no_longer_on_chrome
6 years, 7 months ago (2014-05-08 18:42:59 UTC) #1
Ken Rockot(use gerrit already)
Nice. LGTM w/nit https://codereview.chromium.org/278593005/diff/1/extensions/browser/verified_contents.h File extensions/browser/verified_contents.h (right): https://codereview.chromium.org/278593005/diff/1/extensions/browser/verified_contents.h#newcode23 extensions/browser/verified_contents.h:23: VerifiedContents(const uint8* public_key, int public_key_size); nit: ...
6 years, 7 months ago (2014-05-08 20:05:17 UTC) #2
asargent_no_longer_on_chrome
https://codereview.chromium.org/278593005/diff/1/extensions/browser/verified_contents.h File extensions/browser/verified_contents.h (right): https://codereview.chromium.org/278593005/diff/1/extensions/browser/verified_contents.h#newcode23 extensions/browser/verified_contents.h:23: VerifiedContents(const uint8* public_key, int public_key_size); On 2014/05/08 20:05:17, Ken ...
6 years, 7 months ago (2014-05-08 21:05:45 UTC) #3
asargent_no_longer_on_chrome
The CQ bit was checked by asargent@chromium.org
6 years, 7 months ago (2014-05-08 21:05:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/278593005/20001
6 years, 7 months ago (2014-05-08 21:07:37 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 01:31:31 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-09 03:19:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_dbg/builds/18097) win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/8581)
6 years, 7 months ago (2014-05-09 03:19:29 UTC) #8
asargent_no_longer_on_chrome
The CQ bit was checked by asargent@chromium.org
6 years, 7 months ago (2014-05-09 04:56:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/278593005/30001
6 years, 7 months ago (2014-05-09 05:03:07 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 11:24:43 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-09 13:46:01 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 13:46:01 UTC) #13
Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

Powered by Google App Engine
This is Rietveld 408576698