Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2307)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java

Issue 2785913002: [subresource_filter] Add the Content Settings UI for Android (Closed)
Patch Set: guard via feature list Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java
index 6c148ea209088a8629119f8e7f37e456c0c162ee..7eaed597bcaa2597f57f9e61c8ab9ac441be0c15 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java
@@ -151,6 +151,11 @@ public class ContentSettingsResources {
localMap.put(ContentSettingsType.CONTENT_SETTINGS_TYPE_USB_CHOOSER_DATA,
new ResourceItem(R.drawable.settings_usb, 0, 0, ContentSetting.ASK,
ContentSetting.BLOCK, 0, 0));
+ localMap.put(ContentSettingsType.CONTENT_SETTINGS_TYPE_SUBRESOURCE_FILTER,
+ new ResourceItem(R.drawable.permission_popups,
Finnur 2017/03/31 10:22:34 This is the wrong icon to use. You should consult
Charlie Harrison 2017/03/31 13:21:42 Is there a way we can just use an existing icon as
Finnur 2017/03/31 13:47:23 That's what you are doing now, isn't it? There are
Charlie Harrison 2017/03/31 14:56:46 Yeah, that was my intention with reusing the popup
+ R.string.subresource_filter_header_android,
+ R.string.subresource_filter_header_android, ContentSetting.ALLOW,
+ ContentSetting.BLOCK, 0, 0));
Finnur 2017/03/31 10:22:34 These blocks are alphabetically ordered based on t
Charlie Harrison 2017/03/31 13:21:41 Done.
sResourceInfo = localMap;
}
return sResourceInfo;

Powered by Google App Engine
This is Rietveld 408576698