ios/clean/chrome/browser/ui/ntp/new_tab_page_view_controller.h - Issue 2785893003: [ios clean] Add placeholder for NTP bookmarks, chrome home and open tabs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/clean/chrome/browser/ui/ntp/new_tab_page_view_controller.h

Issue 2785893003: [ios clean] Add placeholder for NTP bookmarks, chrome home and open tabs. (Closed)

Patch Set: Comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/clean/chrome/browser/ui/ntp/new_tab_page_mediator.mm ('K') | « ios/clean/chrome/browser/ui/ntp/new_tab_page_mediator.mm ('k') | ios/clean/chrome/browser/ui/ntp/new_tab_page_view_controller.mm » ('j') | ios/clean/chrome/browser/ui/ntp/new_tab_page_view_controller.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_NTP_NEW_TAB_PAGE_VIEW_CONTROLLER_H_	5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_NTP_NEW_TAB_PAGE_VIEW_CONTROLLER_H_

6 #define IOS_CLEAN_CHROME_BROWSER_UI_NTP_NEW_TAB_PAGE_VIEW_CONTROLLER_H_	6 #define IOS_CLEAN_CHROME_BROWSER_UI_NTP_NEW_TAB_PAGE_VIEW_CONTROLLER_H_

7	7

8 #import <UIKit/UIKit.h>	8 #import <UIKit/UIKit.h>

9	9

	10 #import "ios/clean/chrome/browser/ui/commands/ntp_commands.h"

	11 #import "ios/clean/chrome/browser/ui/ntp/new_tab_page_consumer.h"

	12

10 // View controller that displays a new tab page.	13 // View controller that displays a new tab page.

11 @interface NTPViewController : UIViewController	14 @interface NTPViewController : UIViewController<NTPConsumer>

	15 @property(nonatomic, weak) id<NTPCommands> ntpCommandHandler;
	marq (ping after 24h) 2017/04/05 12:22:48 just 'commandHandler' is fine, or (more likely) 'd just 'commandHandler' is fine, or (more likely) 'dispatcher'. justincohen 2017/04/05 19:28:24 Done. Show quoted text On 2017/04/05 12:22:48, marq wrote: > just 'commandHandler' is fine, or (more likely) 'dispatcher'. Done.
	16

	17 // Add a Chrome Home panel.

	18 - (void)addHomePanelViewController:(UIViewController*)controller;

	19 // Add a bookmarks panel on iPad or present a bookmarks panel on iPhone.

	20 - (void)addBookmarksViewController:(UIViewController*)controller;

	21 // Add a open tabs panel on iPad or present a bookmarks panel on iPhone.

	22 - (void)addOpenTabsViewController:(UIViewController*)controller;

	23 // Add an incognito panel.

	24 - (void)addIncognitoViewController:(UIViewController*)controller;

12 @end	25 @end

13	26

14 #endif // IOS_CLEAN_CHROME_BROWSER_UI_NTP_NEW_TAB_PAGE_VIEW_CONTROLLER_H_	27 #endif // IOS_CLEAN_CHROME_BROWSER_UI_NTP_NEW_TAB_PAGE_VIEW_CONTROLLER_H_

OLD	NEW