ios/clean/chrome/browser/ui/ntp/new_tab_page_consumer.h - Issue 2785893003: [ios clean] Add placeholder for NTP bookmarks, chrome home and open tabs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/clean/chrome/browser/ui/ntp/new_tab_page_consumer.h

Issue 2785893003: [ios clean] Add placeholder for NTP bookmarks, chrome home and open tabs. (Closed)

Patch Set: Comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_NTP_NEW_TAB_PAGE_CONSUMER_H_

	6 #define IOS_CLEAN_CHROME_BROWSER_UI_NTP_NEW_TAB_PAGE_CONSUMER_H_

	7

	8 @protocol NTPConsumer

	9

	10 // Tell NTP what tab bar items to display.
	marq (ping after 24h) 2017/04/05 12:22:48 "Tab bar" is kind of confusing because these are t "Tab bar" is kind of confusing because these are tabs in the UITabBar sense, not tabs in the Chrome sense. justincohen 2017/04/05 19:28:23 removed the word tab. Show quoted text On 2017/04/05 12:22:48, marq wrote: > "Tab bar" is kind of confusing because these are tabs in the UITabBar sense, not > tabs in the Chrome sense. removed the word tab.
	11 - (void)setTabBarItems:(NSMutableArray*)item;
	marq (ping after 24h) 2017/04/05 12:22:48 Generic on the array? Name the parameter 'items', Generic on the array? Name the parameter 'items', since it's a collection. justincohen 2017/04/05 19:28:24 Done. Show quoted text On 2017/04/05 12:22:48, marq wrote: > Generic on the array? > > Name the parameter 'items', since it's a collection. Done.
	12

	13 @end

	14

	15 #endif // IOS_CLEAN_CHROME_BROWSER_UI_NTP_NEW_TAB_PAGE_CONSUMER_H_

OLD	NEW