Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Side by Side Diff: ios/clean/chrome/browser/ui/ntp/BUILD.gn

Issue 2785893003: [ios clean] Add placeholder for NTP bookmarks, chrome home and open tabs. (Closed)
Patch Set: Address various comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2017 The Chromium Authors. All rights reserved. 1 # Copyright 2017 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 source_set("ntp") { 5 source_set("ntp") {
6 sources = [ 6 sources = [
7 "new_tab_page_coordinator.h", 7 "new_tab_page_coordinator.h",
8 "new_tab_page_coordinator.mm", 8 "new_tab_page_coordinator.mm",
9 "new_tab_page_home_coordinator.h",
10 "new_tab_page_home_coordinator.mm",
11 "new_tab_page_home_mediator.h",
12 "new_tab_page_home_mediator.mm",
13 "new_tab_page_mediator.h",
14 "new_tab_page_mediator.mm",
9 ] 15 ]
10 16
11 configs += [ "//build/config/compiler:enable_arc" ] 17 configs += [ "//build/config/compiler:enable_arc" ]
12 18
13 deps = [ 19 deps = [
14 ":ntp_ui", 20 ":ntp_ui",
21 "//ios/chrome/app/strings:ios_strings_grit",
22 "//ios/chrome/browser/ui:ui",
lpromero 2017/04/06 13:01:04 Idem for not repeating the target when it can be i
justincohen 2017/04/06 18:25:09 Done.
23 "//ios/chrome/browser/ui/ntp:ntp_internal",
24 "//ios/chrome/browser/ui/toolbar:toolbar",
25 "//ios/clean/chrome/browser/ui/bookmarks/",
26 "//ios/clean/chrome/browser/ui/commands:commands",
27 "//ios/clean/chrome/browser/ui/open_tabs/",
lpromero 2017/04/06 13:01:04 Remove the trailing slash.
justincohen 2017/04/06 18:25:09 Done.
15 "//ios/shared/chrome/browser/coordinator_context", 28 "//ios/shared/chrome/browser/coordinator_context",
29 "//ios/shared/chrome/browser/ui/browser_list:browser_list",
30 "//ios/shared/chrome/browser/ui/commands:commands",
16 "//ios/shared/chrome/browser/ui/coordinators", 31 "//ios/shared/chrome/browser/ui/coordinators",
32 "//ios/web:web_arc",
33 "//ui/base:base",
34 "//url:url",
17 ] 35 ]
18 } 36 }
19 37
20 source_set("ntp_ui") { 38 source_set("ntp_ui") {
21 sources = [ 39 sources = [
40 "new_tab_page_consumer.h",
22 "new_tab_page_view_controller.h", 41 "new_tab_page_view_controller.h",
23 "new_tab_page_view_controller.mm", 42 "new_tab_page_view_controller.mm",
24 ] 43 ]
25 44
26 configs += [ "//build/config/compiler:enable_arc" ] 45 configs += [ "//build/config/compiler:enable_arc" ]
27 46
28 deps = [ 47 deps = [
29 "//base", 48 "//base",
30 "//components/strings:components_strings_grit", 49 "//components/strings:components_strings_grit",
31 "//ios/chrome/app/strings:ios_strings_grit", 50 "//ios/chrome/app/strings:ios_strings_grit",
51 "//ios/chrome/browser/ui:ui",
32 "//ios/chrome/browser/ui/ntp:ntp_internal", 52 "//ios/chrome/browser/ui/ntp:ntp_internal",
33 "//ios/clean/chrome/browser/ui", 53 "//ios/clean/chrome/browser/ui",
54 "//ios/clean/chrome/browser/ui/commands:commands",
34 "//ui/base:base", 55 "//ui/base:base",
35 ] 56 ]
36 } 57 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698