[ios clean] Add placeholder for NTP bookmarks, chrome home and open tabs.

ios/clean/chrome/browser/ui/bookmarks/bookmarks_coordinator.mm

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import "ios/clean/chrome/browser/ui/bookmarks/bookmarks_coordinator.h"
+
+#import "ios/chrome/browser/ui/bookmarks/bookmark_controller_factory.h"
+#import "ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.h"
+#import "ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.h"
+#include "ios/chrome/browser/ui/ui_util.h"
+#import "ios/shared/chrome/browser/coordinator_context/coordinator_context.h"
+#import "ios/shared/chrome/browser/ui/browser_list/browser.h"
+#import "ios/shared/chrome/browser/ui/coordinators/browser_coordinator+internal.h"
+
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
+@interface BookmarksCoordinator ()
+@property(nonatomic, strong) UIViewController* viewController;
+@property(nonatomic, strong)
+    BookmarkHomeTabletNTPController* wrapperViewController;

[lpromero, 2017/04/06 13:01:04]

This class is not a view controller. Consider renaming the property.

[justincohen, 2017/04/06 18:25:09]

Done, here and everywhere.

+@end
+
+@implementation BookmarksCoordinator
+@synthesize viewController = _viewController;
+@synthesize wrapperViewController = _wrapperViewController;
+
+- (void)start {
+  // HACK: Re-using old view controllers for now.
+  if (!IsIPadIdiom()) {
+    self.viewController = [[BookmarkHomeHandsetViewController alloc]
+        initWithLoader:nil
+          browserState:self.browser->browser_state()];
+    self.viewController.modalPresentationStyle = UIModalPresentationFormSheet;
+  } else {
+    BookmarkControllerFactory* factory =
+        [[BookmarkControllerFactory alloc] init];
+    self.wrapperViewController = [factory
+        bookmarkPanelControllerForBrowserState:self.browser->browser_state()
+                                        loader:nil
+                                    colorCache:nil];
+    self.viewController = [[UIViewController alloc] init];
+    self.viewController.view = [self.wrapperViewController view];

[rohitrao (ping after 24h), 2017/04/06 13:08:13]

Is it ok to assign to |view| like this, or should we subclass and implement
loadView?

[marq (ping after 24h), 2017/04/06 14:30:13]

|view| is a public writable property, so implicitly this is OK. Note that
setting |view| will not trigger |viewDidLoad| as far as I know.

However, it is worth noting that the UIViewController docs say "Each view
controller object is the sole owner of its view. You must not associate the same
view object with multiple view controller objects. The only exception to this
rule is that a container view controller implementation may add this view as a
subview in its own view hierarchy."

[justincohen, 2017/04/06 18:25:09]

This is a temporary solution that will go away..

[justincohen, 2017/04/06 18:25:09]

I think this is OK for now.

+  }
+  [super start];
+}
+
+@end