ios/clean/chrome/browser/ui/bookmarks/bookmarks_coordinator.h - Issue 2785893003: [ios clean] Add placeholder for NTP bookmarks, chrome home and open tabs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/clean/chrome/browser/ui/bookmarks/bookmarks_coordinator.h

Issue 2785893003: [ios clean] Add placeholder for NTP bookmarks, chrome home and open tabs. (Closed)

Patch Set: Address various comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_BOOKMARKS_BOOKMARKS_COORDINATOR_H_

	6 #define IOS_CLEAN_CHROME_BROWSER_UI_BOOKMARKS_BOOKMARKS_COORDINATOR_H_

	7

	8 #import <UIKit/UIKit.h>
	lpromero 2017/04/06 13:01:04 Add new line. Add new line. justincohen 2017/04/06 18:25:09 Done. Show quoted text On 2017/04/06 13:01:04, lpromero wrote: > Add new line. Done.
	9 #import "ios/shared/chrome/browser/ui/coordinators/browser_coordinator.h"

	10

	11 @interface BookmarksCoordinator : BrowserCoordinator
	lpromero 2017/04/06 13:01:04 Comment. Comment. justincohen 2017/04/06 18:25:09 Done. Show quoted text On 2017/04/06 13:01:04, lpromero wrote: > Comment. Done.
	12 @end
	lpromero 2017/04/06 13:01:04 Please add a unit tests file and a simple test tha Please add a unit tests file and a simple test that the view controller is set up correctly when started. justincohen 2017/04/06 18:25:09 Added unittest but it's just a stub for now. Show quoted text On 2017/04/06 13:01:04, lpromero wrote: > Please add a unit tests file and a simple test that the view controller is set > up correctly when started. Added unittest but it's just a stub for now.
	13

	14 #endif // IOS_CLEAN_CHROME_BROWSER_UI_BOOKMARKS_BOOKMARKS_COORDINATOR_H_

OLD	NEW