ios/clean/chrome/browser/ui/bookmarks/BUILD.gn - Issue 2785893003: [ios clean] Add placeholder for NTP bookmarks, chrome home and open tabs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/clean/chrome/browser/ui/bookmarks/BUILD.gn

Issue 2785893003: [ios clean] Add placeholder for NTP bookmarks, chrome home and open tabs. (Closed)

Patch Set: Address various comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2017 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 source_set("bookmarks") {

	6 sources = [

	7 "bookmarks_coordinator.h",

	8 "bookmarks_coordinator.mm",

	9 ]

	10

	11 configs += [ "//build/config/compiler:enable_arc" ]

	12

	13 deps = [

	14 "//ios/chrome/browser/ui:ui",
	lpromero 2017/04/06 13:01:04 No need to repeat the target name when it's the fo No need to repeat the target name when it's the folder name. Here and below twice. justincohen 2017/04/06 18:25:09 Done. Show quoted text On 2017/04/06 13:01:04, lpromero wrote: > No need to repeat the target name when it's the folder name. Here and below > twice. Done.
	15 "//ios/chrome/browser/ui/bookmarks:bookmarks",

	16 "//ios/shared/chrome/browser/coordinator_context",

	17 "//ios/shared/chrome/browser/ui/browser_list:browser_list",

	18 "//ios/shared/chrome/browser/ui/coordinators",

	19 ]

	20 }

OLD	NEW