chromeos/network/onc/onc_utils_unittest.cc - Issue 2785883003: Use unique_ptr<DictionaryValue> in ProxyConfigDictionary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_utils_unittest.cc

Issue 2785883003: Use unique_ptr<DictionaryValue> in ProxyConfigDictionary (Closed)

Patch Set: Fix compilation Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/onc/onc_utils_unittest.cc

diff --git a/chromeos/network/onc/onc_utils_unittest.cc b/chromeos/network/onc/onc_utils_unittest.cc

index ba4a2ed1c66f28dbf22da7003d8458554aea5332..92cbceb1136d6765cabd8171bd8f5a8c8ecb0a91 100644

--- a/chromeos/network/onc/onc_utils_unittest.cc

+++ b/chromeos/network/onc/onc_utils_unittest.cc

@@ -225,7 +225,8 @@ TEST(ONCUtils, ProxyConfigToOncProxySettings) {

test_case->GetDictionary("ONC_ProxySettings", &onc_proxy_settings);

std::unique_ptr<base::DictionaryValue> actual_proxy_settings =

- ConvertProxyConfigToOncProxySettings(*shill_proxy_config);

+ ConvertProxyConfigToOncProxySettings(

+ shill_proxy_config->CreateDeepCopy());

EXPECT_TRUE(

test_utils::Equals(onc_proxy_settings, actual_proxy_settings.get()));

}