Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: components/policy/core/browser/proxy_policy_handler_unittest.cc

Issue 2785883003: Use unique_ptr<DictionaryValue> in ProxyConfigDictionary (Closed)
Patch Set: one constructor Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/browser/proxy_policy_handler_unittest.cc
diff --git a/components/policy/core/browser/proxy_policy_handler_unittest.cc b/components/policy/core/browser/proxy_policy_handler_unittest.cc
index 6a70b7fb4c16aa2d5b91c02d062e02413c1c9b1c..76ea7084ee0f1b0c58137cd96384556225726a2f 100644
--- a/components/policy/core/browser/proxy_policy_handler_unittest.cc
+++ b/components/policy/core/browser/proxy_policy_handler_unittest.cc
@@ -48,7 +48,7 @@ class ProxyPolicyHandlerTest
ASSERT_TRUE(store_->GetValue(proxy_config::prefs::kProxy, &value));
ASSERT_EQ(base::Value::Type::DICTIONARY, value->GetType());
ProxyConfigDictionary dict(
- static_cast<const base::DictionaryValue*>(value));
+ static_cast<const base::DictionaryValue*>(value)->CreateDeepCopy());
std::string s;
if (expected_proxy_server.empty()) {
EXPECT_FALSE(dict.GetProxyServer(&s));

Powered by Google App Engine
This is Rietveld 408576698