components/policy/core/browser/proxy_policy_handler_unittest.cc - Issue 2785883003: Use unique_ptr<DictionaryValue> in ProxyConfigDictionary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/browser/proxy_policy_handler_unittest.cc

Issue 2785883003: Use unique_ptr<DictionaryValue> in ProxyConfigDictionary (Closed)

Patch Set: one constructor Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/policy/core/browser/proxy_policy_handler_unittest.cc

diff --git a/components/policy/core/browser/proxy_policy_handler_unittest.cc b/components/policy/core/browser/proxy_policy_handler_unittest.cc

index 6a70b7fb4c16aa2d5b91c02d062e02413c1c9b1c..76ea7084ee0f1b0c58137cd96384556225726a2f 100644

--- a/components/policy/core/browser/proxy_policy_handler_unittest.cc

+++ b/components/policy/core/browser/proxy_policy_handler_unittest.cc

@@ -48,7 +48,7 @@ class ProxyPolicyHandlerTest

ASSERT_TRUE(store_->GetValue(proxy_config::prefs::kProxy, &value));

ASSERT_EQ(base::Value::Type::DICTIONARY, value->GetType());

ProxyConfigDictionary dict(

- static_cast<const base::DictionaryValue*>(value));

+ static_cast<const base::DictionaryValue*>(value)->CreateDeepCopy());

std::string s;

if (expected_proxy_server.empty()) {

EXPECT_FALSE(dict.GetProxyServer(&s));