Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: chromeos/network/proxy/proxy_config_service_impl.cc

Issue 2785883003: Use unique_ptr<DictionaryValue> in ProxyConfigDictionary (Closed)
Patch Set: one constructor Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/proxy/proxy_config_service_impl.cc
diff --git a/chromeos/network/proxy/proxy_config_service_impl.cc b/chromeos/network/proxy/proxy_config_service_impl.cc
index 3536e803524e7dbe5202a773946c5cb1ea32cf51..e348f58565ad304b03279f27ed1344e978b4f293 100644
--- a/chromeos/network/proxy/proxy_config_service_impl.cc
+++ b/chromeos/network/proxy/proxy_config_service_impl.cc
@@ -193,7 +193,8 @@ ProxyConfigServiceImpl::GetActiveProxyConfigDictionary(
bool value_exists = pref->GetValue()->GetAsDictionary(&proxy_config_value);
DCHECK(value_exists);
- return base::MakeUnique<ProxyConfigDictionary>(proxy_config_value);
+ return base::MakeUnique<ProxyConfigDictionary>(
+ proxy_config_value->CreateDeepCopy());
}
const NetworkState* network =

Powered by Google App Engine
This is Rietveld 408576698