chrome/browser/extensions/api/proxy/proxy_apitest.cc - Issue 2785883003: Use unique_ptr<DictionaryValue> in ProxyConfigDictionary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/proxy/proxy_apitest.cc

Issue 2785883003: Use unique_ptr<DictionaryValue> in ProxyConfigDictionary (Closed)

Patch Set: one constructor Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/proxy/proxy_apitest.cc

diff --git a/chrome/browser/extensions/api/proxy/proxy_apitest.cc b/chrome/browser/extensions/api/proxy/proxy_apitest.cc

index 61ebbd4c0b3d7900a7717072971f9eea4acc338c..7df0ebb87e303feb47ff68422e51a0e6c5b84753 100644

--- a/chrome/browser/extensions/api/proxy/proxy_apitest.cc

+++ b/chrome/browser/extensions/api/proxy/proxy_apitest.cc

@@ -37,7 +37,8 @@ class ProxySettingsApiTest : public ExtensionApiTest {

EXPECT_TRUE(pref->IsExtensionControlled());

ProxyConfigDictionary dict(

- pref_service->GetDictionary(proxy_config::prefs::kProxy));

+ pref_service->GetDictionary(proxy_config::prefs::kProxy)

+ ->CreateDeepCopy());

ProxyPrefs::ProxyMode mode;

ASSERT_TRUE(dict.GetMode(&mode));