Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1457)

Unified Diff: chrome/browser/extensions/api/proxy/proxy_apitest.cc

Issue 2785883003: Use unique_ptr<DictionaryValue> in ProxyConfigDictionary (Closed)
Patch Set: one constructor Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/proxy/proxy_apitest.cc
diff --git a/chrome/browser/extensions/api/proxy/proxy_apitest.cc b/chrome/browser/extensions/api/proxy/proxy_apitest.cc
index 61ebbd4c0b3d7900a7717072971f9eea4acc338c..7df0ebb87e303feb47ff68422e51a0e6c5b84753 100644
--- a/chrome/browser/extensions/api/proxy/proxy_apitest.cc
+++ b/chrome/browser/extensions/api/proxy/proxy_apitest.cc
@@ -37,7 +37,8 @@ class ProxySettingsApiTest : public ExtensionApiTest {
EXPECT_TRUE(pref->IsExtensionControlled());
ProxyConfigDictionary dict(
- pref_service->GetDictionary(proxy_config::prefs::kProxy));
+ pref_service->GetDictionary(proxy_config::prefs::kProxy)
+ ->CreateDeepCopy());
ProxyPrefs::ProxyMode mode;
ASSERT_TRUE(dict.GetMode(&mode));

Powered by Google App Engine
This is Rietveld 408576698