Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/api/proxy/proxy_api.cc

Issue 2785883003: Use unique_ptr<DictionaryValue> in ProxyConfigDictionary (Closed)
Patch Set: comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/proxy_config_service_impl_unittest.cc ('k') | chrome/browser/extensions/api/proxy/proxy_api_helpers.h » ('j') | components/proxy_config/proxy_config_dictionary.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/proxy/proxy_api.cc
diff --git a/chrome/browser/extensions/api/proxy/proxy_api.cc b/chrome/browser/extensions/api/proxy/proxy_api.cc
index c2ad7f37bb291d80d482386b5a1c04e01f5af898..7f7717e6dec00032a96249321058ec11ee8a2658 100644
--- a/chrome/browser/extensions/api/proxy/proxy_api.cc
+++ b/chrome/browser/extensions/api/proxy/proxy_api.cc
@@ -133,9 +133,10 @@ base::Value* ProxyPrefTransformer::ExtensionToBrowserPref(
return NULL;
}
- return helpers::CreateProxyConfigDict(
- mode_enum, pac_mandatory, pac_url, pac_data, proxy_rules_string,
- bypass_list, error);
+ return helpers::CreateProxyConfigDict(mode_enum, pac_mandatory, pac_url,
+ pac_data, proxy_rules_string,
+ bypass_list, error)
+ .release();
}
base::Value* ProxyPrefTransformer::BrowserToExtensionPref(
« no previous file with comments | « chrome/browser/chromeos/proxy_config_service_impl_unittest.cc ('k') | chrome/browser/extensions/api/proxy/proxy_api_helpers.h » ('j') | components/proxy_config/proxy_config_dictionary.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698