Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: components/proxy_config/proxy_config_dictionary_unittest.cc

Issue 2785883003: Use unique_ptr<DictionaryValue> in ProxyConfigDictionary (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/proxy_config/proxy_config_dictionary_unittest.cc
diff --git a/components/proxy_config/proxy_config_dictionary_unittest.cc b/components/proxy_config/proxy_config_dictionary_unittest.cc
index 33f5364c14b7160005d3a2c7711033473a920f1c..7a45824e21be006d82eaeaa49268d0ab8d15d229 100644
--- a/components/proxy_config/proxy_config_dictionary_unittest.cc
+++ b/components/proxy_config/proxy_config_dictionary_unittest.cc
@@ -18,8 +18,8 @@ struct ProxyConfigHolder {
};
TEST(ProxyConfigDictionaryTest, CreateDirect) {
- std::unique_ptr<base::DictionaryValue> dict_value(
- ProxyConfigDictionary::CreateDirect());
+ std::unique_ptr<base::DictionaryValue> dict_value =
+ ProxyConfigDictionary::CreateDirect();
ProxyConfigDictionary dict(dict_value.get());
ProxyConfigHolder h;
@@ -31,8 +31,8 @@ TEST(ProxyConfigDictionaryTest, CreateDirect) {
}
TEST(ProxyConfigDictionaryTest, CreateAutoDetect) {
- std::unique_ptr<base::DictionaryValue> dict_value(
- ProxyConfigDictionary::CreateAutoDetect());
+ std::unique_ptr<base::DictionaryValue> dict_value =
+ ProxyConfigDictionary::CreateAutoDetect();
ProxyConfigDictionary dict(dict_value.get());
ProxyConfigHolder h;
@@ -44,8 +44,8 @@ TEST(ProxyConfigDictionaryTest, CreateAutoDetect) {
}
TEST(ProxyConfigDictionaryTest, CreatePacScript) {
- std::unique_ptr<base::DictionaryValue> dict_value(
- ProxyConfigDictionary::CreatePacScript("pac", false));
+ std::unique_ptr<base::DictionaryValue> dict_value =
+ ProxyConfigDictionary::CreatePacScript("pac", false);
ProxyConfigDictionary dict(dict_value.get());
ProxyConfigHolder h;
@@ -58,9 +58,8 @@ TEST(ProxyConfigDictionaryTest, CreatePacScript) {
}
TEST(ProxyConfigDictionaryTest, CreateFixedServers) {
- std::unique_ptr<base::DictionaryValue> dict_value(
- ProxyConfigDictionary::CreateFixedServers("http://1.2.3.4",
- "http://foo"));
+ std::unique_ptr<base::DictionaryValue> dict_value =
+ ProxyConfigDictionary::CreateFixedServers("http://1.2.3.4", "http://foo");
ProxyConfigDictionary dict(dict_value.get());
ProxyConfigHolder h;
@@ -74,8 +73,8 @@ TEST(ProxyConfigDictionaryTest, CreateFixedServers) {
}
TEST(ProxyConfigDictionaryTest, CreateSystem) {
- std::unique_ptr<base::DictionaryValue> dict_value(
- ProxyConfigDictionary::CreateSystem());
+ std::unique_ptr<base::DictionaryValue> dict_value =
+ ProxyConfigDictionary::CreateSystem();
ProxyConfigDictionary dict(dict_value.get());
ProxyConfigHolder h;

Powered by Google App Engine
This is Rietveld 408576698