Use unique_ptr<DictionaryValue> in ProxyConfigDictionary

chrome/browser/extensions/api/proxy/proxy_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implementation of the Chrome Extensions Proxy Settings API.
 
 #include "chrome/browser/extensions/api/proxy/proxy_api.h"
 
 #include <memory>
 #include <utility>
@@ skipping 115 matching lines @@
           config, &pac_url, error, bad_message) ||
       !helpers::GetPacDataFromExtensionPref(
           config, &pac_data, error, bad_message) ||
       !helpers::GetProxyRulesStringFromExtensionPref(
           config, &proxy_rules_string, error, bad_message) ||
       !helpers::GetBypassListFromExtensionPref(
           config, &bypass_list, error, bad_message)) {
     return NULL;
   }
 
-  return helpers::CreateProxyConfigDict(
-      mode_enum, pac_mandatory, pac_url, pac_data, proxy_rules_string,
-      bypass_list, error);
+  return helpers::CreateProxyConfigDict(mode_enum, pac_mandatory, pac_url,
+                                        pac_data, proxy_rules_string,
+                                        bypass_list, error)
+      .release();
 }
 
 base::Value* ProxyPrefTransformer::BrowserToExtensionPref(
     const base::Value* browser_pref) {
   CHECK(browser_pref->IsType(base::Value::Type::DICTIONARY));
 
   // This is a dictionary wrapper that exposes the proxy configuration stored in
   // the browser preferences.
   ProxyConfigDictionary config(
-      static_cast<const base::DictionaryValue*>(browser_pref));
+      static_cast<const base::DictionaryValue*>(browser_pref)
+          ->CreateDeepCopy());
 
   ProxyPrefs::ProxyMode mode;
   if (!config.GetMode(&mode)) {
     LOG(ERROR) << "Cannot determine proxy mode.";
     return NULL;
   }
 
   // Build a new ProxyConfig instance as defined in the extension API.
   std::unique_ptr<base::DictionaryValue> extension_pref(
       new base::DictionaryValue);
@@ skipping 26 matching lines @@
       extension_pref->Set(keys::kProxyConfigRules, proxy_rules_dict);
       break;
     }
     case ProxyPrefs::kModeCount:
       NOTREACHED();
   }
   return extension_pref.release();
 }
 
 }  // namespace extensions