third_party/WebKit/Source/web/ContextMenuClientImpl.cpp - Issue 2785853002: Selection Action mode triggered like a context menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

Issue 2785853002: Selection Action mode triggered like a context menu (Closed)

Patch Set: fix rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp b/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

index 854c49a2bb39c4bb09e52ebf285d12525674c135..e8ee3ca2d258319dd277bbea1fa44c925dcc50f4 100644

--- a/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

+++ b/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

@@ -197,7 +197,7 @@ bool ContextMenuClientImpl::ShouldShowContextMenuFromTouch(

!data.link_url.IsEmpty() ||

data.media_type == WebContextMenuData::kMediaTypeImage ||

data.media_type == WebContextMenuData::kMediaTypeVideo ||

- data.is_editable;

+ data.is_editable || !data.selected_text.IsEmpty();

}

static HTMLFormElement* AssociatedFormElement(HTMLElement& element) {