content/browser/renderer_host/input/touch_selection_controller_client_aura.cc - Issue 2785853002: Selection Action mode triggered like a context menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/touch_selection_controller_client_aura.cc

Issue 2785853002: Selection Action mode triggered like a context menu (Closed)

Patch Set: fix rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/stylus_text_selector_unittest.cc ('k') | content/browser/renderer_host/render_widget_host_view_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/touch_selection_controller_client_aura.cc

diff --git a/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc b/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc

index 8fb31d7467474617d29b7f3414161fac59e3cafa..199df163b43b590c002255a1fd9e1bb402c4d18c 100644

--- a/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc

+++ b/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc

@@ -170,6 +170,12 @@ bool TouchSelectionControllerClientAura::HandleContextMenu(

UpdateQuickMenu();

return true;

}

+ const bool from_touch = params.source_type == ui::MENU_SOURCE_LONG_PRESS ||

+ params.source_type == ui::MENU_SOURCE_TOUCH;

+ if (from_touch && !params.selection_text.empty())

+ return true;

rwhva_->selection_controller()->HideAndDisallowShowingAutomatically();

return false;

}