third_party/WebKit/Source/core/editing/SelectionController.h - Issue 2785853002: Selection Action mode triggered like a context menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/SelectionController.h

Issue 2785853002: Selection Action mode triggered like a context menu (Closed)

Patch Set: fixing tests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/SelectionController.h

diff --git a/third_party/WebKit/Source/core/editing/SelectionController.h b/third_party/WebKit/Source/core/editing/SelectionController.h

index ba1714322527b9c26dfdf1abb866cceff91244a1..b6dda5a30c130059918fb2ed6f0ef4f290cf4a11 100644

--- a/third_party/WebKit/Source/core/editing/SelectionController.h

+++ b/third_party/WebKit/Source/core/editing/SelectionController.h

@@ -102,7 +102,7 @@ class CORE_EXPORT SelectionController final

SelectInputEventType);

void SelectClosestMisspellingFromHitTestResult(const HitTestResult&,

AppendTrailingWhitespace);

- void SelectClosestWordFromMouseEvent(const MouseEventWithHitTestResults&);

+ bool SelectClosestWordFromMouseEvent(const MouseEventWithHitTestResults&);

yosin_UTC9 2017/05/25 04:47:21 Please add a comment for |bool| return value.

amaralp1 2017/05/25 07:11:56 Done.

void SelectClosestMisspellingFromMouseEvent(

const MouseEventWithHitTestResults&);

void SelectClosestWordOrLinkFromMouseEvent(